Skip to content

/ Rocket

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copyright owner information is missing from Apache License file #1290

Open
klingtnet opened this issue Apr 27, 2020 · 1 comment
Open

Copyright owner information is missing from Apache License file #1290

klingtnet opened this issue Apr 27, 2020 · 1 comment
Assignees
@SergioBenitez
Labels
docs

Comments

@klingtnet
Copy link

@klingtnet klingtnet commented Apr 27, 2020 •
edited

Please fill out this line: LICENSE-APACHE#L189

...
Copyright [yyyy] [name of copyright owner]
...
@jebrosen jebrosen added the docs label Apr 27, 2020
@ralpha
Copy link

@ralpha ralpha commented May 8, 2020

Was going to note the same thing. Also:

Looking in crates.io I also noticed your license states:

Rocket/core/lib/Cargo.toml

Line 13 in 1010f6a

license = "MIT/Apache-2.0"

Maybe consider changing this to:

license = "MIT OR Apache-2.0"

Then it is written the same way as other rust-lang licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergioBenitez SergioBenitez

Labels
docs
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@SergioBenitez @klingtnet @ralpha @jebrosen
You can’t perform that action at this time.