QL language specification: bring library path documentation up to date#3476
QL language specification: bring library path documentation up to date#3476hmakholm merged 5 commits intogithub:masterfrom hmakholm:pr/module-res-update
Conversation
|
Perhaps it would be better to put the new section a level higher, between "Architecture" and "Name Resolution"? |
Thanks so much for this PR @hmakholm! I will review the text changes shortly. |
|
OK, I've force-pushed an amended commit that moves the new section. |
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Thanks again for writing this @hmakholm! I've made some minor suggestions for clarity/consistency.
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
This looks good from my point of view! Over to @alexet for any technical comments.
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
shati-patel
changed the title
Put 'the query directory of the current file` back in the description.
|
@shati-patel It now looks good to me from a technical point of view. Do you want have a another look from a wording point of view for the changes? |
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
|
Thanks @shati-patel. Unfortunately fixing the typo cancelled the existing approvals so I'll need a new one :-) |
3 participants
This part of the documentation was out of date by not mentioning QL packs, or identifying query directories by
qlpack.ymlfiles.I think it was also incorrect when it implied that an
importstatement in a library will be resolved against a query directory found releative to the.qllrather than the query directory of the original.qlfile. (At least I can't find any code that would implement that behavior).Closes: https://github.com/github/semmle-docs/issues/91
Review: @alexet for technical accuracy, @shati-patel for wording and organization.