JavaScript: Model extra sinks in vm module#3468
Merged
semmle-qlci merged 2 commits intogithub:masterfrom May 18, 2020
Merged
Conversation
Contributor
|
LGTM, but lets preserve backwards-compatibility. I believe we have done something like this in a few places: /**
* DEPRCATED Use `VmModuleMemberInvocation` instead.
*/
deprecated
class VmModuleMethodCall = VmModuleMemberInvocation; |
Contributor
Author
|
Good suggestion, done.
…On Thu, 14 May 2020 at 12:47, Esben Sparre Andreasen < ***@***.***> wrote:
LGTM, but lets preserve backwards-compatibility.
I believe we have done something like this in a few places:
/** * DEPRCATED Use `VmModuleMemberInvocation` instead. */ deprecatedclass VmModuleMethodCall = VmModuleMemberInvocation;
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3468 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDFWXVTN35KTAEBBYJ2HTDRRPK45ANCNFSM4NAP5QPQ>
.
|
esbena
approved these changes
May 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few extra sinks for code injection to our NodeJS models -- basically, anything with a
codeparameter in the documentation of thevmmodule.Renaming the existing library class is technically a breaking change, since it is public (though not in the global namespace). If you prefer, I could retain it while introducing a supertype for
InvokeNodes and a secondary subclass of that supertype forVmModuleConstructorInvocation.