Skip to content

/ certbot

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Certbot snap to be based on Ubuntu 20.04 #7854

Open
bmw opened this issue Mar 18, 2020 · 4 comments
Open

Update Certbot snap to be based on Ubuntu 20.04 #7854

bmw opened this issue Mar 18, 2020 · 4 comments
Labels
area: pkging area: snaps easy-fix priority: significant
Milestone
1.6.0

Comments

@bmw
Copy link
Member

@bmw bmw commented Mar 18, 2020 •
edited

Here we define the base image of the Certbot snap to be core18 which is based on Ubuntu 18.04.

Probably the single most problematic part of packaging Certbot as a snap is going to be when we have to change the base snap in the future which may require all externally packaged plugins to have to upgrade in order to continue to work. More details about this can be found at https://docs.google.com/document/d/1OB5WCDz2mBMgRvtnvo4FSjWHPBDlt1NpccJ5sNrhWIw/edit?usp=sharing.

To delay these problems for as long as possible, I think we should be using the core20 image based on Ubuntu 20.04 before we publish a stable Certbot snap. I think we may want to consider doing this before adding support for external plugins (see #7667), but I think that'll depend on the state of the core20 snap and Ubuntu 20.04. Apparently, it already exists, but I'm not sure how stable it is yet. See

$ snap info core20
name:      core20
summary:   Runtime environment based on Ubuntu 20.04
publisher: Canonical✓
license:   unset
description: |
  The base snap based on the Ubuntu 20.04 release.
type:    base
snap-id: DLqre5XGLbDqg9jPtiAhRRjDuPVa5X1q
channels:
  stable:    20 2020-02-10 (347) 62MB -
  candidate: 20 2020-02-10 (347) 62MB -
  beta:      20 2020-03-16 (486) 62MB -
  edge:      20 2020-03-17 (496) 62MB -

We should probably look into the state of things with core20 more when we go to work on this issue.
@bmw bmw added this to the 1.5.0 milestone Mar 18, 2020
@bmw
Copy link
Member Author

@bmw bmw commented Apr 23, 2020 •
edited

When we do this, we probably will need to update the Python version in snapcraft.yml as flagged by Adrien at #7932 (comment) and #7932 (comment).
This was referenced Apr 23, 2020
Closed
Open
@enoch85
Copy link

@enoch85 enoch85 commented Apr 24, 2020

Quick question, if installing the snap package on Ubuntu 20.04, will it stop working after you pushed the new snap core?
@bmw
Copy link
Member Author

@bmw bmw commented Apr 24, 2020

As far as I know it shouldn't. It should seamlessly upgrade to the new snap using the new base.
@bmw bmw added the easy-fix label May 5, 2020
@bmw
Copy link
Member Author

@bmw bmw commented May 19, 2020 •
edited

I started this in the core20 branch, but it failed because it seems you need snapcraft >= 4.0 which isn't in the stable channel yet. You can see the failure that occurs when trying to use an older version of snapcraft at https://travis-ci.com/github/certbot/certbot/builds/166993202.

We could update to the candidate channel and remember to downgrade later, but it seems easiest to me to just wait a bit if we can.

Also, when resolving this issue, we should remember to update the snap-plugin branch with the same changes including updating certbot-dns-dnsimple/snap/snapcraft.yaml to also be based on core20.
@bmw bmw modified the milestones: 1.5.0, 1.6.0 May 19, 2020
@bmw bmw mentioned this issue May 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: pkging area: snaps easy-fix priority: significant
Projects
None yet
Milestone
  1.6.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@enoch85 @bmw
You can’t perform that action at this time.