Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS ARN service portion should be fixed, account randomized, maybe region kept #10

Open
lvh opened this issue May 3, 2020 · 1 comment
Open

Comments

@lvh
Copy link
Contributor

@lvh lvh commented May 3, 2020

Seen as arn:aws:cloudtrail:us-east-1:123456789012:trail/mytrailname mapping to arn:aws:83s8p0ju4w87prn1p7j:::Kj. This mostly just looks ridiculous. Some groups are empty because ARNs do legitimately allow them to be.

Would be cool if the account ID gets redacted separately, so that account IDs still get redacted, but two ARNs that are otherwise completely different will map the same account ID to the same account ID. Also, if the account ID occurs elsewhere, it'll similarly get redacted identically.

lvh added a commit that referenced this issue May 5, 2020
Refs #10.
@lvh
Copy link
Contributor Author

@lvh lvh commented May 19, 2020

If we keep the region, #13 suddenly becomes moot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.