classification
Title: Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g
Type: Stage: patch review
Components: macOS, Windows Versions: Python 3.9, Python 3.8, Python 3.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: christian.heimes, lukasz.langa, miss-islington, ned.deily, paul.moore, ronaldoussoren, steve.dower, tim.golden, zach.ware
Priority: deferred blocker Keywords: patch

Created on 2020-04-03 00:56 by ned.deily, last changed 2020-05-18 15:28 by ned.deily.

Pull Requests
URL Status Linked Edit
PR 19359 merged steve.dower, 2020-04-04 12:14
PR 19361 merged steve.dower, 2020-04-04 14:22
PR 19362 merged steve.dower, 2020-04-04 14:24
PR 19642 merged ned.deily, 2020-04-22 02:14
PR 19643 merged miss-islington, 2020-04-22 02:41
PR 19644 merged miss-islington, 2020-04-22 02:41
Messages (13)
msg365657 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-04-03 00:56
1.1.1f released 2020-03-31

Reminder to Windows team to update Windows build.

Reminder to macOS team to update macOS installer build.
(note: please don't submit a PR or patch for this!)

https://www.openssl.org/source/
msg365727 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-04-03 21:50
I've pushed new binaries for OpenSSL 1.1.1f on Windows. I'll try and to the rest over the weekend, but if someone else wants to do the PCbuild PR feel free.
msg365764 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-04-04 14:19
New changeset a1d4dbdfc78e3aed4c245e1810ef24eaa4e744c2 by Steve Dower in branch 'master':
bpo-40164: Update Windows to OpenSSL 1.1.1f (GH-19359)
https://github.com/python/cpython/commit/a1d4dbdfc78e3aed4c245e1810ef24eaa4e744c2
msg365766 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-04-04 14:47
New changeset 37126e7bd242bce03f3c4f208d8871edd3febcbe by Steve Dower in branch '3.8':
bpo-40164: Update Windows to OpenSSL 1.1.1f (GH-19359)
https://github.com/python/cpython/commit/37126e7bd242bce03f3c4f208d8871edd3febcbe
msg365767 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-04-04 14:47
New changeset e7a47c23dd25a144ec4afc2db46393818694926f by Steve Dower in branch '3.7':
bpo-40164: Update Windows to OpenSSL 1.1.1f (GH-19359)
https://github.com/python/cpython/commit/e7a47c23dd25a144ec4afc2db46393818694926f
msg366932 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-04-21 17:34
And today (2020-04-21) 1.1.1g is released with a high severity fix.
msg366940 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-04-21 21:02
That'll teach me for being so quick on this...

Are we even impacted by the issue though? I don't see any calls to SSL_check_chain() in our code or the SSL sources.

Advisory: https://www.openssl.org/news/secadv/20200421.txt
Full diff: https://github.com/openssl/openssl/compare/OpenSSL_1_1_1f...OpenSSL_1_1_1g
msg366955 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-04-21 23:43
> Are we even impacted by the issue though?

Certainly we use a check_chain function at least indirectly but, whether that path is vulnerable, dunno.

But, in any case, we will no doubt be pinged about it so best to be ahead of the curve, I think.
msg366970 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-04-22 02:41
New changeset 783a673f23c5e9ffafe12fe172e119dc0fa2abda by Ned Deily in branch 'master':
bpo-40164: Update macOS installer builds to use OpenSSL 1.1.1g. (GH-19642)
https://github.com/python/cpython/commit/783a673f23c5e9ffafe12fe172e119dc0fa2abda
msg366971 - (view) Author: miss-islington (miss-islington) Date: 2020-04-22 03:00
New changeset 9e51aab37e9af6fa0fe406fd56184a0aded28e11 by Miss Islington (bot) in branch '3.8':
bpo-40164: Update macOS installer builds to use OpenSSL 1.1.1g. (GH-19642)
https://github.com/python/cpython/commit/9e51aab37e9af6fa0fe406fd56184a0aded28e11
msg366972 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-04-22 03:04
New changeset 7ad3adda9bff8a9055eaf0b66489e8204f1e7cc6 by Miss Islington (bot) in branch '3.7':
bpo-40164: Update macOS installer builds to use OpenSSL 1.1.1g. (GH-19642) (GH-19644)
https://github.com/python/cpython/commit/7ad3adda9bff8a9055eaf0b66489e8204f1e7cc6
msg369244 - (view) Author: Ɓukasz Langa (lukasz.langa) * (Python committer) Date: 2020-05-18 15:24
Should this still be open?
msg369245 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-05-18 15:28
I believe the Windows builds are still using 1.1.1f.
History
Date User Action Args
2020-05-18 15:28:33ned.deilysetmessages: + msg369245
2020-05-18 15:24:36lukasz.langasetnosy: + lukasz.langa
messages: + msg369244
2020-04-22 03:04:19ned.deilysetmessages: + msg366972
2020-04-22 03:00:34miss-islingtonsetmessages: + msg366971
2020-04-22 02:41:56miss-islingtonsetpull_requests: + pull_request18968
2020-04-22 02:41:48miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request18967
2020-04-22 02:41:40ned.deilysetmessages: + msg366970
2020-04-22 02:14:17ned.deilysetpull_requests: + pull_request18966
2020-04-21 23:43:26ned.deilysetmessages: + msg366955
2020-04-21 21:02:35steve.dowersetnosy: + christian.heimes
messages: + msg366940
2020-04-21 17:34:05ned.deilysetmessages: + msg366932
title: Upgrade Windows and macOS installer builds to OpenSSL 1.1.1f -> Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g
2020-04-04 14:47:50steve.dowersetmessages: + msg365767
2020-04-04 14:47:46steve.dowersetmessages: + msg365766
2020-04-04 14:24:34steve.dowersetpull_requests: + pull_request18724
2020-04-04 14:22:24steve.dowersetpull_requests: + pull_request18723
2020-04-04 14:19:15steve.dowersetmessages: + msg365764
2020-04-04 12:14:36steve.dowersetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request18721
2020-04-03 21:50:15steve.dowersetmessages: + msg365727
2020-04-03 00:56:28ned.deilycreate