Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade the test farm tests to use Python 3 #7857
Closed
Comments
|
@ohemorange is investigating. |
|
Just going to start a list of some relevant reminders for myself
|
bmw
pushed a commit
that referenced
this issue
Apr 9, 2020
Fixes #7857. * stop using urllib2 in test farm tests * use six for urllib instead * remove fabric lcd usage * correct lcd removal * remove fabric cd * convert some remote calls to v2 * move more cxns to v2 * get run working with prefix * get sudo commands working * remove final fabric v1 references including local * update requirements and README * add new venv to gitignore * update version used in travis * remove deploy_script unused kwargs * fix killboulder implementation so I can test creating a new boulder server * hardcode the gopath due to broken env manamagement in fabric2 * Update letstest readme * move the comment about hardcoding the ggopath * catch BaseException instead of Exception * work around fabric #2007 * use connections as context managers to ensure they're closed * remove reference to virtualenv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our test farm test script only supports Python 2 which reached its end-of-life and going to become harder and harder to install. It has been removed from Homebrew and is planned to be removed from Ubuntu 20.04 LTS. So we can continue to trigger tests locally which is necessary to do Certbot releases, we should make the script work with Python 3. I do not think we should keep Python 2 compatibility when doing this.
To do this, we at least need to:
urllib2and instead use urllib.There may be other issues I'm not aware of but that should be most of the work with the most significant work being upgrading Fabric which revamped its API.