Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Veggieseasons sample drops frames while scrolling #297

Open
YmiYugy opened this issue Jun 17, 2019 · 4 comments
Open

Veggieseasons sample drops frames while scrolling #297

YmiYugy opened this issue Jun 17, 2019 · 4 comments
Assignees
Labels
p2
Milestone

Comments

@YmiYugy
Copy link

@YmiYugy YmiYugy commented Jun 17, 2019

I noticed that the veggieseasons sample app drops below 60fps while scrolling through the veggies on the home screen.
I get an average of around 20ms/frame GPU time and max GPU time of around 30 ms/frame.
So it only runs about 50fps, which seems like a small deviation but on a fixed refresh display it leads to micro stuttering.

Test Setup:

Flutter 1.7.4 release build.
I turned on the performance overlay by adding to showPerformanceOverlay: true to the CupertinoApp widget.
I testest both on a Galaxy S8 with Android 9.0
and a iPad 6th generation running iOS 12.3.1
Both had similar frame times.

I know that these are not fastest devices but it is just a simple list after all and I would expect scrolling to be smooth.

@YmiYugy
Copy link
Author

@YmiYugy YmiYugy commented Jun 18, 2019

I've done some more testing and it's probably obvious but, disabling the blur CupertinoSliverNavigationBar by selecting an opaque color solves the problem, but is not really what I want.
I would assume that the blur functionality in Skia is already well optimized, but then again, it isn't a problem in native iOS apps.

@ericmartineau
Copy link

@ericmartineau ericmartineau commented Aug 1, 2019

The scrolling was smooth in 1.5.x and has since regressed.
flutter/flutter#36064

As noted in the other issue, I've tested this with the veggieseasons app specifically

@ericmartineau
Copy link

@ericmartineau ericmartineau commented Aug 2, 2019

Video with performance overlay of the two versions:

Screencast v.1.7.8+hotfix.4 (youtube)
Screencast v.1.5.8 (youtube)

@kf6gpe kf6gpe transferred this issue from flutter/flutter Jan 30, 2020
@RedBrogdon RedBrogdon self-assigned this Jan 31, 2020
@RedBrogdon RedBrogdon added the p2 label Jan 31, 2020
@RedBrogdon RedBrogdon added this to the On Deck milestone Jan 31, 2020
@RedBrogdon
Copy link
Contributor

@RedBrogdon RedBrogdon commented Jan 31, 2020

CC: @HansMuller

Clearly we needed our own issue tracker for the samples for a while now.

I don't have an iOS hardware device on me today, but I'll try to verify if this problem still exists with the current SDK early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.