Clarification about mandatory Flag in Produce Class #1039

Gsantomaggio · 2019-04-09T20:37:40Z

Hi,
Why the mandatory flag is marked as not_supported on the documentation and inside the code?

I tried it and seems to work correctly:

env:

pip freeze
amqp==2.4.2
kombu==4.5.0
PyAMQP==0.0.7.1
...

code:

from __future__ import absolute_import, unicode_literals

from kombu import Connection, Producer


def on_return(exception, _exchange, routing_key, _message):
    print("Exception: %s, routing_key: %s" % (exception, routing_key))


with Connection('amqp://guest:guest@localhost:5672//') as connection:
    producer = Producer(connection, on_return=on_return)
    producer.publish({'hello': 'mandatory'}, mandatory=True,
                     routing_key='queue_does_not_exist')

result:

Exception: Basic.return: (312) NO_ROUTE, routing_key: queue_does_not_exist

312 NO_ROUTE is exactly the AMQP error code

Thank you

auvipy · 2019-04-15T12:44:02Z

PR is welcome

Gsantomaggio · 2019-04-15T12:49:22Z

@auvipy thank you,
I am asking why the mandatory flag is considered not_supported.
I will be glag to make a PR to remove the info on the documentation, but I'd like to know your opinion on it.

matteius · 2019-08-23T04:55:41Z

@Gsantomaggio the answer is because mandatory flag was added in 2010 by @ask and added to the docstrings as not supported and passed along all the way into the transports basic_publish kwargs and then never used within kombu, but the kwargs are sometimes passed for example in the virtual base transport it passed it to self._put which seems to ignore it, but perhaps some transport has been implemented that could use a mandatory flag? I am not sure the intention but it kind of feels like something that isn't mandatory and could be removed from the code base if you ask me.

# anon exchange: routing_key is the destination queue
return self._put(routing_key, message, **kwargs)

auvipy closed this May 5, 2020

celery / kombu

Clarification about mandatory Flag in Produce Class #1039

Clarification about mandatory Flag in Produce Class #1039

Gsantomaggio commented Apr 9, 2019

auvipy commented Apr 15, 2019

Gsantomaggio commented Apr 15, 2019

matteius commented Aug 23, 2019 •

edited

celery / kombu

Sponsor celery/kombu

Join GitHub today

GitHub is where the world builds software

Clarification about mandatory Flag in Produce Class #1039

Clarification about mandatory Flag in Produce Class #1039

Comments

Gsantomaggio commented Apr 9, 2019

auvipy commented Apr 15, 2019

Gsantomaggio commented Apr 15, 2019

matteius commented Aug 23, 2019 • edited

Essential cookies

Always active

Analytics cookies

matteius commented Aug 23, 2019 •

edited