bpo-40002: Fix http.cookies.BaseCookie.load inconsistent errors#19059
Open
bharel wants to merge 13 commits intopython:mainfrom
Open
bpo-40002: Fix http.cookies.BaseCookie.load inconsistent errors#19059bharel wants to merge 13 commits intopython:mainfrom
bharel wants to merge 13 commits intopython:mainfrom
Conversation
aviramha
reviewed
Mar 18, 2020
Contributor
Author
|
No need, docs already state it should throw CookieError. Just need to figure out how to clear all edge cases. |
and yet it didn't and now behavior is changed, hence I think if someone encounters this while upgrading he wont know that there's any behavior change. |
Contributor
Author
|
Done, ready for upload. No http experts for nosy, triage needed. |
Contributor
Author
|
Still relevant, should I change the version indicator in the docs? |
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the inconsistent error throwing.
https://bugs.python.org/issue40002