build: fix elements test failures on IE #35940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following issues which caused the `elements` unit tests to break on IE: 1. `core.js` wasn't included which caused an error about `Promise` and `Symbol` to be thrown. 2. We were using a version of `@webcomponents/custom-elements` which was shipping ES6 code to npm. As a result, IE was throwing a syntax error.
gkalpak
approved these changes
Mar 10, 2020
matsko
added a commit
that referenced
this issue
Mar 10, 2020
Fixes the following issues which caused the `elements` unit tests to break on IE: 1. `core.js` wasn't included which caused an error about `Promise` and `Symbol` to be thrown. 2. We were using a version of `@webcomponents/custom-elements` which was shipping ES6 code to npm. As a result, IE was throwing a syntax error. PR Close #35940
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes the following issues which caused the
elementsunit tests to break on IE:core.jswasn't included which caused an error aboutPromiseandSymbolto be thrown.@webcomponents/custom-elementswhich was shipping ES6 code to npm. As a result, IE was throwing a syntax error.