Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs-infra): fix resources page tabs text which is not visible on… #35935

Closed
wants to merge 4 commits into from
Closed

fix(docs-infra): fix resources page tabs text which is not visible on… #35935

wants to merge 4 commits into from

Conversation

ajitsinghkaler
Copy link
Contributor

@ajitsinghkaler ajitsinghkaler commented Mar 8, 2020

… small screens

on small mobile screens the top tab bar contains text which was not visible on small screens changed text size, margin and padding so that the text could be contained in these screens (320px to 480px)

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

On small screents tab text on resources page was not visible
Angular - EXPLORE ANGULAR RESOURCES (1)

Issue Number: N/A

What is the new behavior?

On small screents tab text on resources page is not visible
Angular - EXPLORE ANGULAR RESOURCES

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from petebacondarwin Mar 8, 2020
@ajitsinghkaler
Copy link
Contributor Author

@ajitsinghkaler ajitsinghkaler commented Mar 10, 2020

@petebacondarwin can you please review this

@matsko matsko added the comp: docs-infra label Mar 10, 2020
@ngbot ngbot bot added this to the needsTriage milestone Mar 10, 2020
@mary-poppins
Copy link

@mary-poppins mary-poppins commented Mar 11, 2020

You can preview 14c21b3 at https://pr35935-14c21b3.ngbuilds.io/.
You can preview 58b3094 at https://pr35935-58b3094.ngbuilds.io/.

@petebacondarwin petebacondarwin added target: patch action: merge labels Mar 11, 2020
gkalpak
gkalpak requested changes Mar 11, 2020
View changes
aio/src/styles/2-modules/_resources.scss Outdated Show resolved Hide resolved
aio/src/styles/2-modules/_resources.scss Outdated Show resolved Hide resolved
aio/src/styles/2-modules/_resources.scss Outdated Show resolved Hide resolved
aio/src/styles/2-modules/_resources.scss Outdated Show resolved Hide resolved
@gkalpak gkalpak added action: cleanup and removed action: merge labels Mar 11, 2020
@ajitsinghkaler
Copy link
Contributor Author

@ajitsinghkaler ajitsinghkaler commented Mar 25, 2020

@petebacondarwin request for review was sent to you by mistake you need not check this.

@ajitsinghkaler
Copy link
Contributor Author

@ajitsinghkaler ajitsinghkaler commented Mar 25, 2020

@gkalpak can you please have a look

gkalpak
gkalpak requested changes Mar 25, 2020
View changes
Copy link
Member

@gkalpak gkalpak left a comment

Also, the type of the second commit should be style (so style(docs-infra): ...).

aio/src/styles/2-modules/_resources.scss Outdated Show resolved Hide resolved
@ajitsinghkaler ajitsinghkaler requested a review from gkalpak Apr 6, 2020
@ajitsinghkaler
Copy link
Contributor Author

@ajitsinghkaler ajitsinghkaler commented Apr 6, 2020

@gkalpak made the changes please have a look

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Apr 6, 2020

You can preview 89f92ed at https://pr35935-89f92ed.ngbuilds.io/.

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Apr 6, 2020

You can preview f89680b at https://pr35935-f89680b.ngbuilds.io/.

gkalpak
gkalpak requested changes Apr 7, 2020
View changes
aio/src/styles/2-modules/_resources.scss Show resolved Hide resolved
aio/src/styles/2-modules/_resources.scss Outdated Show resolved Hide resolved
@ajitsinghkaler
fix(docs-infra): fix resources page tabs text which is not visible on…
018b61b 
… small screens

on small mobile screens the top tab bar contains text which was not visible on small screens changed text size, margin and padding so that the text could be contained in these screens (320px to 480px)
@mary-poppins
Copy link

@mary-poppins mary-poppins commented Apr 7, 2020

You can preview 08c3e78 at https://pr35935-08c3e78.ngbuilds.io/.

@ajitsinghkaler ajitsinghkaler requested a review from gkalpak Apr 7, 2020
@ajitsinghkaler
Copy link
Contributor Author

@ajitsinghkaler ajitsinghkaler commented Apr 7, 2020

@gkalpak made the changes please have a look

gkalpak
gkalpak approved these changes Apr 7, 2020
View changes
Copy link
Member

@gkalpak gkalpak left a comment

Awesome ✨ Thx, @ajitsinghkaler!

@gkalpak gkalpak removed the request for review from petebacondarwin Apr 7, 2020
@gkalpak gkalpak added action: merge and removed action: cleanup labels Apr 7, 2020
kara added a commit that referenced this issue Apr 7, 2020
@ajitsinghkaler @kara
style(docs-infra): removed extra , from _resources.scss file (#35935)
96a3de6 
there was a typo in _resourcess.scss file there was an extra comma added some spaces too that were needed for proper styling of the code

PR Close #35935
kara added a commit that referenced this issue Apr 7, 2020
@ajitsinghkaler @kara
fix(docs-infra): fix resources page tabs text which is not visible on…
c5384ae 
… small screens (#35935)

on small mobile screens the top tab bar contains text which was not visible on small screens changed text size, margin and padding so that the text could be contained in these screens (320px to 480px)

PR Close #35935
kara added a commit that referenced this issue Apr 7, 2020
@ajitsinghkaler @kara
style(docs-infra): removed extra , from _resources.scss file (#35935)
41a41e7 
there was a typo in _resourcess.scss file there was an extra comma added some spaces too that were needed for proper styling of the code

PR Close #35935
@ajitsinghkaler ajitsinghkaler deleted the resources-css-changes branch Apr 8, 2020
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented May 9, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin

@gkalpak gkalpak

Assignees
No one assigned
Labels
action: merge aio: preview cla: yes comp: docs-infra target: patch type: bug/fix
Projects
None yet
Milestone
needsTriage
Linked issues

Successfully merging this pull request may close these issues.

None yet
6 participants
@ajitsinghkaler @mary-poppins @petebacondarwin @gkalpak @matsko @googlebot