Skip to content

/ html5lib-python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 2.6 #356

Merged
merged 2 commits into from Nov 7, 2017
Merged

Drop support for Python 2.6 #356

merged 2 commits into from Nov 7, 2017

Conversation

@willkg
Copy link
Contributor

@willkg willkg commented Nov 6, 2017

Fixes #330
@willkg
Drop support for Python 2.6
Loading status checks…
0ac0fdc 
Fixes #330
@willkg willkg added this to the 1.0 milestone Nov 6, 2017
@willkg
willkg reviewed Nov 6, 2017
View changes
html5lib/_trie/_base.py Outdated
@@ -13,7 +13,6 @@ def keys(self, prefix=None):
if prefix is None:
return set(keys)

# Python 2.6: no set comprehensions
return set([x for x in keys if x.startswith(prefix)])

This comment has been minimized.

Sign in to view
@willkg

willkg Nov 6, 2017
Author Contributor

Oops--meant to convert this to set comprehension syntax. Will do now.
@willkg
Switch to set comprehension
Loading status checks…
817dff4
@willkg
Copy link
Contributor Author

@willkg willkg commented Nov 7, 2017

@gsnedders @jgraham Can someone review this? The changes involve:

  • removing usage of the ordereddict library
  • switch to using set comprehension syntax
  • removing Python 2.6 and related bits from test environments
  • updating documentation about Python 2.6 support
@gsnedders
gsnedders approved these changes Nov 7, 2017
View changes
@gsnedders gsnedders merged commit 5f637af into html5lib:master Nov 7, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@willkg
Copy link
Contributor Author

@willkg willkg commented Nov 7, 2017

Thank you!
@hugovk hugovk mentioned this pull request Nov 22, 2017
Merged
@willkg willkg deleted the willkg:330-drop-python-26 branch Dec 4, 2017
@kevinmarks kevinmarks mentioned this pull request Mar 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsnedders gsnedders

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@willkg @gsnedders
You can’t perform that action at this time.