Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix scroll to top and toggle menu #1446
Open
Conversation
| @@ -162,10 +162,12 @@ | |||
|
|
|||
| {# Fallback for browsers that do not display generated content... HTML entity will be the icon instead #} | |||
| <a id="close-python-network" class="jump-link" href="#python-network" aria-hidden="true"> | |||
| <span aria-hidden="true" class="icon-arrow-down"><span>▼</span></span> Close | |||
| <span aria-hidden="true" class="icon-arrow-down"><span>▼</span></span> Close / Open | |||
berkerpeksag
Jun 2, 2019
Member
Can we make the default state of the network menu closed instead? Personally, I rarely use them and its current implementation is way more buggy. I think it would be much better if we show it to users on demand.
Can we make the default state of the network menu closed instead? Personally, I rarely use them and its current implementation is way more buggy. I think it would be much better if we show it to users on demand.
|
Fixed the menu to be closed by default.
|
|
LGTM |
This was referenced Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes issue #1278: "Back to top not working properly"
Fixes two scroll to top buttons on smaller screen sizes that now scroll to the top of the screen.
Additionally, this fixes a menu close button at the top that now closes the menu.