Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add Docker development option #1440
Conversation
| musl-dev \ | ||
| postgresql-dev \ | ||
| ruby \ | ||
| ruby-rdoc \ |
berkerpeksag
May 26, 2019
Member
We don't need ruby-rdoc.
We don't need ruby-rdoc.
scottilee
May 26, 2019
Author
Contributor
I added it because the container exits with an error about rdoc. I also tried gem install bundler --no-rdoc but that didn't work. Let me know if you have any other suggestions.
I added it because the container exits with an error about rdoc. I also tried gem install bundler --no-rdoc but that didn't work. Let me know if you have any other suggestions.
scottilee
May 26, 2019
Author
Contributor
Here is the specific error:
ERROR: While executing gem ... (Gem::DocumentError)
RDoc is not installed: cannot load such file -- rdoc/rdoc
Here is the specific error:
ERROR: While executing gem ... (Gem::DocumentError)
RDoc is not installed: cannot load such file -- rdoc/rdoc
berkerpeksag
May 26, 2019
Member
That's weird. I'll look into it, thanks! I thought we've removed it from the Ansible configuration.
That's weird. I'll look into it, thanks! I thought we've removed it from the Ansible configuration.
| fi | ||
|
|
||
| python manage.py migrate | ||
| yes | python manage.py create_initial_data |
berkerpeksag
May 26, 2019
Member
Do we need to invoke this each time? It seems to me that we can make the postgres_data volume persistent.
Do we need to invoke this each time? It seems to me that we can make the postgres_data volume persistent.
berkerpeksag
May 26, 2019
Member
And we can pass --noinput to migrate.
And we can pass --noinput to migrate.
scottilee
May 26, 2019
•
Author
Contributor
I can remove the entrypoint script. Could you let me know how to make the postgres_data volume persistent and how to deal with doing the migrate and create_initial_data separately?
I can remove the entrypoint script. Could you let me know how to make the postgres_data volume persistent and how to deal with doing the migrate and create_initial_data separately?
scottilee
May 26, 2019
Author
Contributor
This looks like an interesting idea but I don't know if it would satisfy what you're looking for: https://stackoverflow.com/a/44283611
This looks like an interesting idea but I don't know if it would satisfy what you're looking for: https://stackoverflow.com/a/44283611
|
@berkerpeksag I did the following, let me know what you want to do about
|
|
I like the idea :-) |
| 2. :ref:`manual-setup` | ||
| 1. :ref:`docker-setup` | ||
| 2. :ref:`vagrant-setup` | ||
| 3. :ref:`manual-setup` |
eamanu
May 26, 2019
•
Contributor
I would like an alphabetical enumeration :-). First docker, second manual setup and finally vagrant setup
Just an opinion
I would like an alphabetical enumeration :-). First docker, second manual setup and finally vagrant setup
Just an opinion
scottilee
May 27, 2019
Author
Contributor
Do you mean the following?
A. Docker Setup
B. Manual Setup
C. Vagrant Setup
If so, as long as @berkerpeksag is okay with it I don't mind.
Do you mean the following?
A. Docker Setup
B. Manual Setup
C. Vagrant Setup
If so, as long as @berkerpeksag is okay with it I don't mind.
eamanu
May 27, 2019
Contributor
Yes, that I mean :-)
Yes, that I mean :-)
|
Per #1441 I am removing the Vagrantfile and mentions of it in the documentation. @berkerpeksag can I get another review please? Also can the merge of this pull request close #1270? |
|
@berkerpeksag If you have time to review this I'd appreciate it! I'm used to using Docker and would love to be able to do that instead of having to set up Vagrant. Thanks. |
|
I would strongly suggest to not use the Alpine image but the new (default) Buster based Python image. Alpine has had some unpleasant side effects in the past that are simply not worth the small size savings it provides. |
Dockerfileanddocker-compose.ymlto bring up python.org in a container along with a Postgres container.