Skip to content

/ peps

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 458: update list of authors #1295

Merged
merged 2 commits into from Feb 4, 2020
Merged

PEP 458: update list of authors #1295

merged 2 commits into from Feb 4, 2020

Conversation

@trishankatdatadog
Copy link
Contributor

@trishankatdatadog trishankatdatadog commented Feb 4, 2020

@mnm678 Any objections?
@trishankatdatadog
update authors
Verified
This commit was signed with a verified signature.
trishankatdatadog Trishank Karthik Kuppusamy
GPG key ID: 5C090ED7318B6C1E Learn about signing commits
Loading status checks…
6885b47
@mnm678
mnm678 approved these changes Feb 4, 2020
View changes
Copy link
Contributor

@mnm678 mnm678 left a comment

LGTM
@Rosuav
Copy link
Contributor

@Rosuav Rosuav commented Feb 4, 2020

It looks like the build system wants consistent email addresses for people, and PEP 480 has a different address @trishankatdatadog . Was your intention to change your address across the board? If so, just add a commit changing PEP 480 as well. If you wanted to have different addresses on different PEPs, though, I'm not sure how to do that.
@trishankatdatadog
update email address & acknowledgements
Verified
This commit was signed with a verified signature.
trishankatdatadog Trishank Karthik Kuppusamy
GPG key ID: 5C090ED7318B6C1E Learn about signing commits
Loading status checks…
ded6686
@trishankatdatadog
Copy link
Contributor Author

@trishankatdatadog trishankatdatadog commented Feb 4, 2020

@Rosuav Done, thanks :)
@Rosuav
Copy link
Contributor

@Rosuav Rosuav commented Feb 4, 2020

LGTM!
@Rosuav Rosuav merged commit 5a9de97 into python:master Feb 4, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@trishankatdatadog trishankatdatadog deleted the trishankatdatadog:pep458/update-authors branch Feb 4, 2020
mnm678 added a commit to mnm678/peps that referenced this pull request Oct 22, 2020
@trishankatdatadog @mnm678
PEP 458: update list of authors (python#1295)
4e2b419 
* update authors

* update email address & acknowledgements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnm678 mnm678

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@trishankatdatadog @Rosuav @mnm678 @the-knights-who-say-ni