Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 405: Removed dead links to Google Code Search #1272

Merged
merged 1 commit into from Jan 10, 2020
Merged

Conversation

@JonDevOps
Copy link
Contributor

@JonDevOps JonDevOps commented Jan 10, 2020

No description provided.

@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Jan 10, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@JonDevOps

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@JonDevOps
Copy link
Contributor Author

@JonDevOps JonDevOps commented Jan 10, 2020

I just signed the CLA. I assume I will have to wait the 1 business day for it to process.

@Rosuav
Copy link
Contributor

@Rosuav Rosuav commented Jan 10, 2020

This is a simple enough change that I can just merge it. Thank you for noticing the breakage.

If someone wants to find a replacement, there are some similar services: https://stackoverflow.com/questions/7778034/replacement-for-google-code-search Alternatively, it might be worth simply searching GitHub.

@Rosuav Rosuav merged commit de18a41 into python:master Jan 10, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JonDevOps
Copy link
Contributor Author

@JonDevOps JonDevOps commented Jan 10, 2020

@Rosuav I'm not sure but this looks like the proper location: https://developers.google.com/code-search.

Again I am not sure though because I never actually used the original code search so its 50/50 that its the right or wrong location.

@Rosuav
Copy link
Contributor

@Rosuav Rosuav commented Jan 10, 2020

Unfortunately the actual code search service is down, so even though there are a few info pages like that one, there's no way to use it to get stats on code usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants