Skip to content

/ peps

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 554: Fix minor typo in marshal example code (#1229) #1230

Merged
merged 2 commits into from Nov 8, 2019
Merged

PEP 554: Fix minor typo in marshal example code (#1229) #1230

merged 2 commits into from Nov 8, 2019

Conversation

@dimitern
Copy link
Contributor

@dimitern dimitern commented Nov 8, 2019

Fixes #1229; CLA signed.

In PEP 554, "Passing objects via marshal" section example code, create_fifo should be create_channel.

@ericsnowcurrently
dimitern added 2 commits Nov 8, 2019
@dimitern
Fix #1229: create_fifo->create_channel in example code
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
eb79c63
@dimitern
Merge pull request #1 from dimitern/dimitern-fix-1229
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
096a242 
PEP 554: Fix typo in marshal example code (#1229)
@ericsnowcurrently
ericsnowcurrently approved these changes Nov 8, 2019
View changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

LGTM :)
@ericsnowcurrently ericsnowcurrently merged commit f42acbe into python:master Nov 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

PEP 554: Minor typo in example code: create_fifo->create_channel
3 participants
@dimitern @ericsnowcurrently @the-knights-who-say-ni