Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 605: Change ABI management to encourage pre-built wheels #1190

Merged

Conversation

@ncoghlan
Copy link
Contributor

@ncoghlan ncoghlan commented Oct 2, 2019

The initial version of the PEP painted a pretty dire picture when it came
to the feasibility of supporting wheels built against the full CPython
ABI on the rolling beta release stream.

I wouldn't actually expect things to be that bad in reality, so this adjusts
the proposal to actively encourage the early creation of wheel archives
targeting the rolling releases.

@ncoghlan ncoghlan requested a review from zooba Oct 2, 2019
pep-0605.rst Outdated Show resolved Hide resolved
pep-0605.rst Outdated Show resolved Hide resolved
pep-0605.rst Outdated Show resolved Hide resolved
pep-0605.rst Outdated Show resolved Hide resolved
pep-0605.rst Outdated Show resolved Hide resolved
pep-0605.rst Show resolved Hide resolved
pep-0605.rst Show resolved Hide resolved
pep-0605.rst Outdated Show resolved Hide resolved
pep-0605.rst Outdated Show resolved Hide resolved
pep-0605.rst Outdated Show resolved Hide resolved
Co-Authored-By: Steve Dower <steve.dower@microsoft.com>
@ncoghlan
Copy link
Contributor Author

@ncoghlan ncoghlan commented Oct 4, 2019

@zooba I've accepted your suggested changes, but your other comments will require more thought and editing. If you're happy to push the current version of the PR as an interim update until, please go ahead and merge.

ncoghlan added 3 commits Oct 4, 2019
@ncoghlan
Copy link
Contributor Author

@ncoghlan ncoghlan commented Oct 4, 2019

OK, I actually addressed the more substantive comments as well. It's a holiday weekend over here, so please merge if you're happy with the updates.

@ncoghlan
Copy link
Contributor Author

@ncoghlan ncoghlan commented Oct 4, 2019

Antoine raised a valid point regarding duplication between the Abstract and the Proposal, so I cut the detailed list of bullet points out of the Abstract.

@ncoghlan
Copy link
Contributor Author

@ncoghlan ncoghlan commented Oct 5, 2019

Added some images based on @ambv's example timeline and support matrix impact in PEP 602.

I also moved the example timeline up the top to reduce the initial "wall of text" impression.

@ambv
Copy link
Contributor

@ambv ambv commented Oct 5, 2019

Good job on the pictures, they are helpful. One question: shouldn't 3.10 start in June rather than May? E.g. branch cut happens at RC?

@ncoghlan
Copy link
Contributor Author

@ncoghlan ncoghlan commented Oct 5, 2019

@ambv Thanks for providing the base images for me to start from! (I'm completely hopeless when I'm looking at a blank screen in an image editor).

Under the current text, there's a 4 month preparation window on master between branching the previous RC, and publishing the initial ABI for the next release series. I'll see what I can do to make it clear that that's intentional. The "2 month RC preparation" window actually means skipping two pre-freeze releases for the next series (one at the start, and one at the end), but it isn't obvious that that results in having 4 months to prepare the first alpha for the next series.

ncoghlan added 2 commits Oct 5, 2019
@ncoghlan ncoghlan merged commit 6a05714 into python:master Oct 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ncoghlan
Copy link
Contributor Author

@ncoghlan ncoghlan commented Oct 5, 2019

I went ahead and merged the update, as the revisions here were substantial enough that reading the previously published version wouldn't give a good understanding of the current state of the proposal.

pprados added a commit to pprados/peps that referenced this pull request Oct 8, 2019
…1190)

* Change ABI management to encourage pre-built wheels
* Actually dedicate a subsection to the 2 year cadence
* Update naming discussion for proposal changes
* Add discussion section for the pre-freeze flag
* Make the abstract much shorter (as suggested by Antoine Pitrou)
* Move example time line up and add pictures (based on PEP 602 images)
* Clarify 4 month window for X.Y.0a1 preparation

Co-Authored-By: Steve Dower <steve.dower@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants