Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing `op_type` shims #200

Open
wants to merge 1 commit into
base: master
from
Open

Removing `op_type` shims #200

wants to merge 1 commit into from

Conversation

@TwP
Copy link
Contributor

@TwP TwP commented Jan 16, 2018

This removes the op_type shim methods from the VersionSupport class. They are no longer needed now that we have parameter validation built into the client.

/cc @elireisman

@TwP TwP requested a review from elireisman Jan 16, 2018
Copy link
Contributor

@elireisman elireisman left a comment

Excellent, thanks! :shipit:

@elireisman
Copy link
Contributor

@elireisman elireisman commented Jan 16, 2018

Prereq: before we upgrade the gem in github/github with this checked in, I'll need to deploy this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.