Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Terragrunt ignore file. #3244

Open
wants to merge 1 commit into
base: master
from

Conversation

@lazzurs
Copy link

@lazzurs lazzurs commented Nov 20, 2019

Terragrunt uses local caching directories as part of the run in their
repo. Ignoring the cache directory.

https://github.com/gruntwork-io/terragrunt

Terragrunt uses local caching directories as part of the run in their
repo. Ignoring the cache directory.

https://github.com/gruntwork-io/terragrunt
@drothmaler
Copy link
Contributor

@drothmaler drothmaler commented Nov 20, 2019

The github site states:

Terragrunt is a thin wrapper for Terraform that provides extra tools [...]

So couldn‘t this just be added to the existing Terraform.gitignore, instead of creating a new one?

@lazzurs
Copy link
Author

@lazzurs lazzurs commented Nov 21, 2019

I would be happy to add this to the existing Terraform file if you think that is best but not everyone that uses Terraform will use Terragrunt and so would end up with lines in their git ignore they don't need.

@drothmaler
Copy link
Contributor

@drothmaler drothmaler commented Nov 21, 2019

Well a lot of files here contain lines for optional addons/extension/whatever, so I don’t see a reason to create a new file for just 2 lines.

I think it also depends on how common terragrunt is. Not sure if this is representative, but Terragrunt has >3000 stars on GitHub vs. >19.000 for Terraform. For me this seems to be common enough to put it into the Terraform.gitignore...

But I‘m just a contributor like you; maybe @shiftkey can give some guidance about it.

@lazzurs
Copy link
Author

@lazzurs lazzurs commented Nov 22, 2019

If someone with merge access can provide guidance either way happy to provide another PR if the guidance is to put it into the file with Terraform.

@lazzurs
Copy link
Author

@lazzurs lazzurs commented Dec 10, 2019

@shiftkey should I be making this just an addition to Terraform or are you happy with it as a new file for a new tool?

@yyrjlw
Copy link

@yyrjlw yyrjlw commented Dec 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants