add rudimentary support for rendering components from controllers#235
Merged
Conversation
This change introduces the ability to render components from controllers, mimicking the behavior introduced in rails/rails#37919. [Fixes: #38]
jonspalmer
reviewed
Feb 29, 2020
| inline_response = response.body | ||
|
|
||
| assert_equal baseline_response, inline_response | ||
| end |
Contributor
There was a problem hiding this comment.
Wouldn't this be a little better as two tests. I'd like to see a test saying "we didn't break regular rendering with our monkey patch" I think that's what you mean by baseline.
jonspalmer
approved these changes
Feb 29, 2020
Contributor
jonspalmer
left a comment
jonspalmer
left a comment
There was a problem hiding this comment.
I like it. We have a bunch of places where we'd use this.
Member
Author
|
@jonspalmer right now, this just renders the component without a layout, matching the behavior of rendering partials from controllers. Is that the behavior you'd expect? Or would you expect layouts to work? |
Contributor
|
I think without layouts is what I'd expect. Otherwise you'd get double rendered layouts or the like. I'd need to go review the examples in more detail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces the ability to render components from
controllers, mimicking the behavior introduced in
rails/rails#37919.
[Fixes: #38]