Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to limit rows per query for admin. #3469

Open
xiaoyu-tamu opened this issue Dec 3, 2019 · 4 comments
Open

How to limit rows per query for admin. #3469

xiaoyu-tamu opened this issue Dec 3, 2019 · 4 comments

Comments

@xiaoyu-tamu
Copy link

@xiaoyu-tamu xiaoyu-tamu commented Dec 3, 2019

Is there anyway to set limit number of rows for the default admin row?

@xiaoyu-tamu xiaoyu-tamu changed the title How to limit row limit for admin. How to limit rows per query for admin. Dec 3, 2019
@rikinsk
Copy link
Member

@rikinsk rikinsk commented Dec 12, 2019

@xiaoyu-tamu It is currently not possible to limit the number of rows returned for the admin role. the admin role is designed to have full access to the system.

Can you explain your use case for this requirement in some more detail.

@xiaoyu-tamu
Copy link
Author

@xiaoyu-tamu xiaoyu-tamu commented Dec 12, 2019

@rikinsk Yes, Sometimes we execute query in GRAPHIQL without limit parameter accidentally (it happens quite often if people use ctrl + enter to execute query). The query takes long time and may cause browser to crash since it try to render 10 million rows.

@delirehberi
Copy link

@delirehberi delirehberi commented Apr 11, 2020

Maybe we can add a frontend control flow. That control runs when a query wanted to run without the limit parameter. Just asks the user: are you sure run to this command?

@akshay5995
Copy link

@akshay5995 akshay5995 commented May 6, 2020

@lexi-lambda What's the decision on how to handle this ? Is it going to be just an alert in the browser like @delirehberi I'm asking as it's labelled under c/server and not under c/console. I'd like to pick it up either ways. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants