Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 40 million developers.
Sign up
Pinned
8,786 contributions in the last year
Activity overview
Contributed to
nodejs/node,
nxtedition/nxt-lib,
nxtedition/node-http2-proxy
and 5 other
repositories
Contribution activity
December 2019
- ronag/quic JavaScript
Created a pull request in nodejs/node that received 20 comments
stream: first error wins and cannot be overriden
The first stream error is the only one that gets emitted as 'error' or forwarded through callbacks. Also it cannot be overriden or swallowed by _de…
+93
−53
•
20
comments
- stream: simplify isBuf
- benchmark: include writev & callback in benchmark
- stream: pipeline should use req.abort() to destroy response
- stream: refactor Writable buffering
- stream: reset flowing state if no 'readable' or 'data' listeners.
- stream: pipe should not swallow error
- benchmark: manywrites backpressure
- stream: refactor Writable buffering
- stream: avoid unhandled exception when destroy w/ callback.
- doc: add note about fs.close undefined behavior
- http2: make http2/compat.write more http/1 compliant
- console: unregister temporary error listener
- stream: error state timing
- stream: error on multiple callback _destroy
- net: noop destroyed socket
- net: remove duplicate _undestroy
- stream: first `destroy` wins
- [WIP] quic: initial experimental quic implementation
- stream: enable autoDestroy by default
- stream: refactor Writable buffering
- stream: writable write emit all errors async
- stream: reset flowing state if no 'readable' or 'data' listeners.
- http: destroy timeout socket by Agent
- stream: add Transform.by utility function
- http2: fix graceful session close
- doc: add note about fs.close undefined behavior
- stream: first error wins and cannot be overriden
- stream: use callback to properly propagate error
- stream: call _final synchronously
- stream: do not chunk strings and Buffer in Readable.from.
- stream: make all streams error in a pipeline
- fs: synchronize close with other I/O for streams
- doc: deprecate finished
- stream: construct
Created an issue in nodejs/node that received 16 comments
stream: `destroy(err)` predictability
The current official API for destroying is destroy(err). Where the user can supply a custom destroyer on the prototype through _destroy(err, cb) an…
16
comments
- https: Agent.createConnection mutates options object
- mistake
- custom `_destroy` can swallow error?
- http2: `HTTP2Session.destroy` signature differs from `stream.destroy`
- stream: normalized destroy()
- stream, net, http, http2: destroy while active race
- net: `write(cb)` not called if `destroy()`:ed before `'connect'`
- net: pending socket re-use
272
contributions
in private repositories
Dec 2 – Dec 24