Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGeneric Extractor should add short-hash of URL to filename #23191
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
Verbose log
Description
Currently the generic extractor relies on the HTML Title and the last portion of the URL to generate a filename.
Ex:
youtube-dl https://www.w3.org/2010/05/video/mediaevents.htmlgets you a file named:
HTML5 Video-mediaevents.mp4This strategy could easily give filename collisions which result in an erroneous response of "this file has already been downloaded". The filename generated should contain a shorthash (first 8 characters of sha1) of the entire URL, or something similar.
Ex of what the filename should be:
HTML5 Video-mediaevents-fbea3c2c.mp4