Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39648: Expand math.gcd() and math.lcm() to handle multiple arguments. #18604

Merged
merged 4 commits into from Feb 23, 2020
Merged

bpo-39648: Expand math.gcd() and math.lcm() to handle multiple arguments. #18604

merged 4 commits into from Feb 23, 2020

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Feb 22, 2020 •
edited by bedevere-bot

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Feb 22, 2020
@serhiy-storchaka serhiy-storchaka changed the title Expand math.gcd() and math.lcm() to handle multiple arguments. bpo-39648: Expand math.gcd() and math.lcm() to handle multiple arguments. Feb 22, 2020
@codecov
Copy link

codecov bot commented Feb 22, 2020 •
edited

Codecov Report

Merging #18604 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18604   +/-   ##
=======================================
  Coverage   82.06%   82.07%           
=======================================
  Files        1955     1955           
  Lines      584068   584073    +5     
  Branches    44458    44459    +1     
=======================================
+ Hits       479334   479353   +19     
+ Misses      95110    95095   -15     
- Partials     9624     9625    +1
Impacted Files Coverage Δ
Lib/idlelib/runscript.py 19.23% <0.00%> (-1.54%) ⬇️
Lib/test/test_random.py 96.78% <0.00%> (-0.31%) ⬇️
Lib/random.py 88.12% <0.00%> (-0.28%) ⬇️
Modules/socketmodule.c 75.78% <0.00%> (+0.08%) ⬆️
Lib/test/test_io.py 94.92% <0.00%> (+0.09%) ⬆️
Lib/test/test_strptime.py 93.80% <0.00%> (+0.22%) ⬆️
Lib/idlelib/editor.py 51.36% <0.00%> (+0.26%) ⬆️
Objects/listobject.c 91.06% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a025d4c...ba9f44a. Read the comment docs.

mdickinson
mdickinson approved these changes Feb 23, 2020
View changes
Copy link
Member

@mdickinson mdickinson left a comment

LGTM; a couple of suggested wording tweaks in the documentation.

Doc/library/math.rst Outdated Show resolved Hide resolved
Doc/library/math.rst Outdated Show resolved Hide resolved
Doc/library/math.rst Outdated Show resolved Hide resolved
Doc/library/math.rst Outdated Show resolved Hide resolved
Modules/mathmodule.c Show resolved Hide resolved
@serhiy-storchaka @mdickinson
Apply suggestions from code review
88998f7 
Co-Authored-By: Mark Dickinson <dickinsm@gmail.com>
@mdickinson mdickinson merged commit 559e7f1 into python:master Feb 23, 2020
@mdickinson
Copy link
Member

mdickinson commented Feb 23, 2020

Thanks, Serhiy!

@mdickinson mdickinson mentioned this pull request Feb 23, 2020
Closed
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Feb 23, 2020

Thank you for your review Mark!

@serhiy-storchaka serhiy-storchaka deleted the math-gcd-lcm-multiarg branch Feb 23, 2020
@sthagen sthagen mentioned this pull request Feb 23, 2020
Merged
@namannimmo10 namannimmo10 mentioned this pull request Feb 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@serhiy-storchaka @mdickinson @the-knights-who-say-ni @bedevere-bot