Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicode error can occur when viewing diff for PR files #1908

Closed
StanleyGoldman opened this issue Sep 11, 2018 · 0 comments
Closed

Unicode error can occur when viewing diff for PR files #1908

StanleyGoldman opened this issue Sep 11, 2018 · 0 comments
Labels
bug
Milestone
2.5.9

Comments

@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Sep 11, 2018

  1. Checkout a different branch than PR #1888 as an example
  2. Right click and "View Changes" of any zh-CN.resx file.
  3. Observe error

Note: If you are actually on the branch this error does not occur.

Images

image

image
@meaghanlewis meaghanlewis added this to Low Priority in BUGS Sep 25, 2018
grokys added a commit that referenced this issue Oct 23, 2018
@grokys
Don't change file encoding unnecessarily.
Loading status checks…
84c37c9 
When a file doesn't exist locally, don't change it's encoding to `Encoding.Default`, just leave it be. Fixes #1908.
@grokys grokys mentioned this issue Oct 23, 2018
Merged
@grokys grokys moved this from Low Priority to In Progress in BUGS Oct 23, 2018
BUGS automation moved this from In Progress to Done Oct 29, 2018
@meaghanlewis meaghanlewis added this to the 2.5.9 milestone Oct 29, 2018
@sguthals sguthals mentioned this issue Nov 1, 2018
Closed
@meaghanlewis meaghanlewis removed this from Done in BUGS Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.5.9
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@StanleyGoldman @meaghanlewis
You can’t perform that action at this time.