Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect documentation on failed jobs #1077

Closed
WeatherGod opened this issue May 2, 2019 · 1 comment
Closed

Incorrect documentation on failed jobs #1077

WeatherGod opened this issue May 2, 2019 · 1 comment

Comments

@WeatherGod
Copy link

@WeatherGod WeatherGod commented May 2, 2019

At https://python-rq.org/docs/results/#dealing-with-exceptions, the documentation states: A reference to the job is put on the failed queue.. This seems to no longer be the case as of v1.0? The documentation at https://python-rq.org/docs/exceptions/ does seem correct, though.

In addition, it would be nice to at least include documentation on how users could retain the old behavior of moving failed jobs to a failed queue. I was depending on that feature as part of my system design (I had a small pool of workers delegated to the "failed" queue so that failed jobs wouldn't obstruct processing of good jobs).

@selwin
Copy link
Collaborator

@selwin selwin commented May 6, 2019

I have updated the docs to correct the reference to failed queue.

Unfortunately, there's no built-in way to retain the old behavior as the exception handling mechanism has been completely overhauled.

To replicate the old behavior, you can disable the default exception handler and create an exception handler that pushes jobs to a new "failed" queue.

@selwin selwin closed this Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.