Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Support ECDSA cipher suits #5789
Comments
|
Thanks for the feedback! As long as Go's tls package has those you want to add, feel free to send a pull request! |
|
Close this issue, because it's resolved by #5850 |
Describe the bug
Here https://github.com/gogs/gogs/blob/master/cmd/web.go#L724 we set TLS server cipher suits in our code, but it only contains suits about RSA.
ECDSA cipher suits like TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 are not added.
Meanwhile, the server preferred cure is all ECC cure https://github.com/gogs/gogs/blob/master/cmd/web.go#L721
I'm happy to open a pull request to fix this problem
To Reproduce
Start gogs with ECC certificate
Expected behavior
It should work with ECC certificate
Screenshots
Additional context
[ ]with[x]):log/gogs.log):2019/08/24 23:50:47 http: TLS handshake error from x.x.x.x:60825: tls: no cipher suite supported by both client and server