Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Back button when navigating between notes #2409

Open
laurent22 opened this issue Jan 30, 2020 · 12 comments
Open

Add Back button when navigating between notes #2409

laurent22 opened this issue Jan 30, 2020 · 12 comments

Comments

@laurent22
Copy link
Owner

@laurent22 laurent22 commented Jan 30, 2020

There is already a button to go back to the previous note when clicking on a note link:

image

We'd like this behaviour when navigating between notes too, so for example, if I open "note 1", then "note 2", clicking on the Back button will go back to "note 1". If there is no note to go back to, the button should be grayed out.

There should also be a "forward" button.

The history would be in memory only (doesn't need to be persisted to disk).

@tessus

This comment has been minimized.

Copy link
Collaborator

@tessus tessus commented Jan 30, 2020

Hmm, what's the history limit? After having Joplin open for a few days, the back history will be in the hundreds/thousands.

What should happen to the sidebar? Should the notebook the note was in expanded? Wouldn't we need a forward button as well? (when moving away from the note the folders have to be collapsed, otherwise you'll end up with a huge tree.)
Sorry for all these questions, but for a good firat issue the specs should be clearer.

@mic704b

This comment has been minimized.

Copy link
Contributor

@mic704b mic704b commented Jan 30, 2020

Would you also want a "forward" button?

@tessus

This comment has been minimized.

Copy link
Collaborator

@tessus tessus commented Jan 30, 2020

It depends. I just think that the specs need an overhaul. As mentioned in my previous comment, there are a few items that are not clear. e.g. we can't just let the history keep growing ad infinitum....

@bedwardly-down

This comment has been minimized.

Copy link
Contributor

@bedwardly-down bedwardly-down commented Jan 31, 2020

@tessus, I think that if there was a forward and backward button, the history limit should only exist during a session and then be cleared once the user is done and has exited the app. That's how buffers work in Vim. Of course, maybe add the option to save a possible note group that opens automatically if the user needs to frequently edit specific notes.

Just spitballing ideas here. I hope these make sense.

@laurent22

This comment has been minimized.

Copy link
Owner Author

@laurent22 laurent22 commented Jan 31, 2020

Would you also want a "forward" button?

That would indeed make sense and would probably be expected by users.

@laurent22

This comment has been minimized.

Copy link
Owner Author

@laurent22 laurent22 commented Jan 31, 2020

The history should indeed be in memory and not persisted to disk.

@bedwardly-down

This comment has been minimized.

Copy link
Contributor

@bedwardly-down bedwardly-down commented Jan 31, 2020

Would this fully replace the current implementation when going between linked notes to include when the user opens multiple notes in a row or be an extension of that?

@bensoibj

This comment has been minimized.

Copy link

@bensoibj bensoibj commented Jan 31, 2020

Good idea! Not only a button, but additionally shortcuts would be nice, like ALT+left and ALT+right.

See also feature request #716

@laurent22

This comment has been minimized.

Copy link
Owner Author

@laurent22 laurent22 commented Jan 31, 2020

For shortcuts, let's keep that for a separate issue as this one is a "good first issue" so it needs to be kept relatively simple.

@laurent22

This comment has been minimized.

Copy link
Owner Author

@laurent22 laurent22 commented Jan 31, 2020

Would this fully replace the current implementation when going between linked notes to include when the user opens multiple notes in a row or be an extension of that?

Yes, I would thought that was implied? Like there wouldn't be two back buttons - one for the linked note handling, and one for regular navigation, it's just one back button, which handles both behaviours. If the description needs to be clarified please let me know what should be changed.

@tessus

This comment has been minimized.

Copy link
Collaborator

@tessus tessus commented Jan 31, 2020

the history limit should only exist during a session and then be cleared once the user is done and has exited the app

This is exactly my point. I start the app and it runs until a new update is available. Thus usually a few weeks. So if you created a history worth a few weeks it would be a total overkill and memory hog. This is why I mentioned a limit on the history. Pick a number or a timeframe and use a FIFO queue.

When it comes to persistence I think this is debatable. I really hate it when I restart the app that all notes that were selected in the different folders and their positions are gone.

@wbswbs

This comment has been minimized.

Copy link

@wbswbs wbswbs commented Feb 6, 2020

Is it possible to access that history in the menu, like for instance the list of the last used documents in Libre Office?

I know this is gonna extend the feature, but think of that possibility, before implementing the back button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.