Created on 2020-02-17 14:23 by cheryl.sabella, last changed 2020-02-18 03:28 by terry.reedy.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 18536 | merged | cheryl.sabella, 2020-02-17 14:27 | |
| PR 18541 | merged | miss-islington, 2020-02-18 02:48 | |
| PR 18542 | merged | miss-islington, 2020-02-18 02:48 | |
| Messages (5) | |||
|---|---|---|---|
| msg362149 - (view) | Author: Cheryl Sabella (cheryl.sabella) *  |
Date: 2020-02-17 14:23 | |
Per msg313179, Terry asked to see tests for when the find_good_parse_start() call returns 0 instead of None. There are two cases when a 0 might be returned: 1. If the code is on the first line in the editor beginning with one of the matching keywords and ending in ":\n", such as "def spam():\n". 2. If the code on the first line is entered as "def spam(", then the hyperparser adds the " \n" in its call to set_code and find_good_parse_start returns a 0. |
|||
| msg362167 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2020-02-18 02:48 | |
New changeset ffda25f6b825f3dee493b6f0746266a4dd6989f0 by Cheryl Sabella in branch 'master': bpo-39663: IDLE: Add additional tests for pyparse (GH-18536) https://github.com/python/cpython/commit/ffda25f6b825f3dee493b6f0746266a4dd6989f0 |
|||
| msg362168 - (view) | Author: miss-islington (miss-islington) | Date: 2020-02-18 03:05 | |
New changeset fde0041089de2d13e7c473200fb74d3956203987 by Miss Islington (bot) in branch '3.7': bpo-39663: IDLE: Add additional tests for pyparse (GH-18536) https://github.com/python/cpython/commit/fde0041089de2d13e7c473200fb74d3956203987 |
|||
| msg362169 - (view) | Author: miss-islington (miss-islington) | Date: 2020-02-18 03:05 | |
New changeset 7fd752c1bc637aeca2bd122d07c0ebc379d0d8ca by Miss Islington (bot) in branch '3.8': bpo-39663: IDLE: Add additional tests for pyparse (GH-18536) https://github.com/python/cpython/commit/7fd752c1bc637aeca2bd122d07c0ebc379d0d8ca |
|||
| msg362171 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2020-02-18 03:28 | |
Thank you for tracking this down. The comment was on #32989. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2020-02-18 03:28:33 | terry.reedy | set | nosy:
- miss-islington messages: + msg362171 versions: + Python 3.7, Python 3.8 |
| 2020-02-18 03:05:42 | miss-islington | set | messages: + msg362169 |
| 2020-02-18 03:05:19 | miss-islington | set | nosy:
+ miss-islington messages: + msg362168 |
| 2020-02-18 02:48:54 | miss-islington | set | pull_requests: + pull_request17919 |
| 2020-02-18 02:48:18 | miss-islington | set | pull_requests: + pull_request17918 |
| 2020-02-18 02:48:13 | terry.reedy | set | messages: + msg362167 |
| 2020-02-17 14:27:54 | cheryl.sabella | set | keywords:
+ patch stage: patch review pull_requests: + pull_request17913 |
| 2020-02-17 14:23:16 | cheryl.sabella | create | |