Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent Documents tutorial should reference MenuItem role #22018

Open
erickzhao opened this issue Feb 3, 2020 · 0 comments
Open

Recent Documents tutorial should reference MenuItem role #22018

erickzhao opened this issue Feb 3, 2020 · 0 comments

Comments

@erickzhao
Copy link
Member

@erickzhao erickzhao commented Feb 3, 2020

Our tutorial on the Recent Documents shows developers how to add the ability to open recent documents from the JumpList/Dock Icon of their app with the app.addRecentDocument API.

https://www.electronjs.org/docs/tutorial/recent-documents

However, PR #11166 added a MenuItem role to this from the app's menu. It would be good if the tutorial showed how to do this as well.

bhutraraghav added a commit to bhutraraghav/electron that referenced this issue Jun 30, 2020
solves issue electron#22018 , adapts documentation to the changes made in issue electron#11166
bhutraraghav added a commit to bhutraraghav/electron that referenced this issue Jun 30, 2020
solves issue electron#22018, adapting the changes made by PR#11166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.