Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with --set #3752

Open
YuriyTigiev opened this issue Dec 20, 2019 · 2 comments
Open

Issues with --set #3752

YuriyTigiev opened this issue Dec 20, 2019 · 2 comments
Labels

Comments

@YuriyTigiev
Copy link

@YuriyTigiev YuriyTigiev commented Dec 20, 2019

Problem Description

The option --set doesn't work

Steps to reproduce the behavior:

  1. The command mitmdump.exe -p 8088 --set ssl_version_client=all --set ssl_version_server=all doesn't change configuration

  2. mitmdump.exe -p 8088 --options doesn't show changes

  3. mitmdump.exe --options returns Error starting proxy server: OSError(98, 'Address already in use')

  4. A default config.yaml file is not present for linux and windows versions.

  5. Documentation doesn't contain samples of how to properly use --set options with one or a few parameters.

System Information

Paste the output of "mitmproxy --version" here.

(venv) [root@localhost mitmproxy]# mitmproxy --version
Mitmproxy: 6.0.0.dev (+494, commit 67955fa)
Python: 3.6.8
OpenSSL: OpenSSL 1.1.0j 20 Nov 2018
Platform: Linux-3.10.0-1062.9.1.el7.x86_64-x86_64-with-centos-7.7.1908-Core

C:\Program Files (x86)\mitmproxy\bin>mitmdump --version
Mitmproxy: 4.0.4 binary
Python: 3.6.6
OpenSSL: OpenSSL 1.1.0i 14 Aug 2018
Platform: Windows-10-10.0.17763

@mhils
Copy link
Member

@mhils mhils commented Dec 22, 2019

  1. It does change the option for me.

  2. This is expected behavior. See mitmproxy --help:

--options             Show all options and their default values
  1. You already have a proxy server running.

  2. Options are documented at https://docs.mitmproxy.org/stable/concepts-options/. We're using YAML. The output of --mitmproxy --options incidentally gives you the default configuration.

  3. Your usage of --set seems fine, so I'm not sure what's the issue here.

@YuriyTigiev
Copy link
Author

@YuriyTigiev YuriyTigiev commented Dec 22, 2019

@mhils thank you for your attention

  1. No. I have restarted a notebook (windows 10) and run the program the first time after restart. The same issue was on the centos server. But after a few tries now everything ok.

  2. I saw the configuration, but It was not clear how to change it. I didn't find the source config file.
    If is it possible to add the file to the install package.

  3. The page https://docs.mitmproxy.org/stable/concepts-options/ contains detail information which options admins can use for the run program. If is it possible to add a few examples of how to use these options from the command line below the options' descriptions. It will be really helpful to who first time trying to use this software.

@mhils mhils added kind/docs and removed kind/triage labels Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.