Skip to content

/ go-github

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding body_html #1058

Closed
nico-bock opened this issue Nov 23, 2018 · 5 comments
Closed

Adding body_html #1058

nico-bock opened this issue Nov 23, 2018 · 5 comments
Assignees
@nico-bock
Labels
enhancement good first issue

Comments

@nico-bock
Copy link

@nico-bock nico-bock commented Nov 23, 2018

Hello,
are there plans to integrate body_html, to get the body in a HTML format?
https://developer.github.com/v3/media/
@gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Nov 23, 2018

There are no plans than I'm aware of, @nico-bock, and to my knowledge, this is the first request for it.

However, this would be a great PR for any new contributor to this repo or a new Go developer.

Please check out our CONTRIBUTING.md guide to get started.

Thank you!
@nico-bock
Copy link
Author

@nico-bock nico-bock commented Nov 24, 2018

I implemented it quickly in my fork https://github.com/nico-bock/go-github/releases/tag/19.1.1
I'll have a deeper look into it the next days.
@gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Nov 24, 2018

OK, thanks, @nico-bock. When you are ready, please create a PR against this repo and we will review it from there.
@nico-bock nico-bock mentioned this issue Dec 19, 2018
Closed
@wesleimp
Copy link
Collaborator

@wesleimp wesleimp commented Feb 27, 2020

@gmlewis is it really relevant or can we close it?
@gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Feb 27, 2020

Thank you, @wesleimp. Closing.
@gmlewis gmlewis closed this Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nico-bock nico-bock

Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@gmlewis @nico-bock @wesleimp