Skip to content

/ octodns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConstellixProvider: zone creation and records in one run #467

Merged
merged 2 commits into from Feb 3, 2020
Merged

ConstellixProvider: zone creation and records in one run #467

merged 2 commits into from Feb 3, 2020

Conversation

@yzguy
Copy link
Collaborator

yzguy commented Jan 19, 2020

Fixes #463

Previously you would have to do 2 runs to sync to Constellix, one for zone creation, and another for record creation.

This fixes that by making sure OctoDNS can find the zone ID after it's created.
@yzguy yzguy marked this pull request as ready for review Jan 19, 2020
@yzguy yzguy changed the title ContellixProvider: zone creation and records in one run ConstellixProvider: zone creation and records in one run Jan 19, 2020
@ross
ross reviewed Jan 21, 2020
View changes
octodns/provider/constellix.py Outdated Show resolved Hide resolved
@yzguy yzguy force-pushed the yzguy:constellix_one_run_creation branch from 6d22e81 to 960e28c Feb 3, 2020
@yzguy
ContellixProvider: zone creation and records in one run
Loading status checks…
08af9aa
@yzguy yzguy force-pushed the yzguy:constellix_one_run_creation branch from 960e28c to 08af9aa Feb 3, 2020
@yzguy
Copy link
Collaborator Author

yzguy commented Feb 3, 2020 •
edited

This should be cleaned up and working better.

Constellix charges you for API calls so cutting down on them is important.
@ross
Merge branch 'master' into constellix_one_run_creation
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b9f998e
@ross
ross approved these changes Feb 3, 2020
View changes
@ross ross merged commit acacc29 into github:master Feb 3, 2020
2 checks passed
2 checks passed
ci (2.7)
Details
ci (3.7)
Details
@yzguy yzguy deleted the yzguy:constellix_one_run_creation branch Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ross ross

Assignees

@yzguy yzguy

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Constellix Provider: Fails to create new zone and add requested records in one run
2 participants
@yzguy @ross
You can’t perform that action at this time.