Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected to be more technical #803

Closed
wants to merge 1 commit into from
Closed

Corrected to be more technical #803

wants to merge 1 commit into from

Conversation

@jymok12
Copy link

@jymok12 jymok12 commented Nov 25, 2019

Experience in existing solutions and paradigm migrations is the basis of gh-ost.

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.

Related issue: https://github.com/github/gh-ost/issues/0123456789

Further notes in https://github.com/github/gh-ost/blob/master/.github/CONTRIBUTING.md
Thank you! We are open to PRs, but please understand if for technical reasons we are unable to accept each and any PR

Description

This PR [briefly explain what it does]

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.
Experience in existing solutions and paradigm migrations is the basis of gh-ost.
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Thank you, but I disagree with the change. I think the existing text is more clear

@shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Jan 20, 2020

user @Meenal9936 has been blocked.

@timvaillancourt
Copy link
Contributor

@timvaillancourt timvaillancourt commented Aug 24, 2020

Thank you, but I disagree with the change. I think the existing text is more clear

I also agree the existing text is more clear and I don't see a problem to be solved

Closing this PR but feel free to open a new PR if there is a problem to be solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.