Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upByebug requires Ruby 2.2 #3790
Conversation
Alhadis
approved these changes
Aug 22, 2017
|
I'm all for a quicker build! |
Alhadis
referenced this pull request
Aug 23, 2017
Merged
Added syntax highlighting for Squirrel #3791
lildude
merged commit b541b53
into
master
Aug 24, 2017
lildude
deleted the
lildude/byebug-requires-ruby-2.2
branch
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
lildude commentedAug 22, 2017
The minimum Ruby version required for byebug is now 2.2.0 thanks to deivid-rodriguez/byebug#337. This requirement change has led to our 2.1 builds failing with:
Rather than locking us to a particular version of byebug, I've bumped the minimum Ruby version to 2.2.0 and I've also defined a
:debuggroup and excluded it in the Travis build so byebug is not installed during testing as it's not needed during testing.One less gem means a slightly quicker build too😄
/cc @github/data-engineering