Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import errors for solver in powermixing app #419

Merged
merged 1 commit into from Feb 27, 2020

Conversation

@sbellem
Copy link
Collaborator

@sbellem sbellem commented Jan 7, 2020

Related to #417.

@sbellem sbellem requested a review from amiller Jan 7, 2020
@sbellem
Copy link
Collaborator Author

@sbellem sbellem commented Jan 7, 2020

Note: The CircleCI check will get resolved once #418 is merged.

@sbellem sbellem mentioned this pull request Jan 27, 2020
1 of 4 tasks complete
Copy link
Contributor

@amiller amiller left a comment

good this is package scoped now

Related to #417.
@sbellem sbellem force-pushed the sbellem:fix-import-errors-in-powermixing-app branch from bafbb0f to 11738a0 Feb 26, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 26, 2020

Codecov Report

Merging #419 into dev will increase coverage by 0.03581%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##                 dev        #419         +/-   ##
===================================================
+ Coverage   77.18890%   77.22471%   +0.03580%     
===================================================
  Files             50          50                 
  Lines           5585        5585                 
  Branches         856         856                 
===================================================
+ Hits            4311        4313          +2     
  Misses          1097        1097                 
+ Partials         177         175          -2     
@sbellem sbellem merged commit b15b7fd into initc3:dev Feb 27, 2020
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
codecov/patch 86.32479% of diff hit (target 77.18890%)
Details
codecov/project 77.22471% (+0.03581%) compared to c3b7f63
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.