Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build from python2 branch of katsdpdockerbase #7

Merged
merged 1 commit into from Jan 10, 2020
Merged

Build from python2 branch of katsdpdockerbase #7

merged 1 commit into from Jan 10, 2020

Conversation

@bmerry
Copy link
Contributor

@bmerry bmerry commented Jan 9, 2020

In preparation for katsdpdockerbase master stripping out Python 2.

@bmerry bmerry requested a review from mauch Jan 9, 2020
@bmerry
Copy link
Contributor Author

@bmerry bmerry commented Jan 9, 2020

The first build will probably fail because katsdpdockerbase:python2 will still be building.

@mauch
mauch approved these changes Jan 9, 2020
Copy link
Contributor

@mauch mauch left a comment

Assuming it builds I'm happy with this.

@bmerry
Copy link
Contributor Author

@bmerry bmerry commented Jan 9, 2020

Urgh, looks like it has failed. So it is probably not related to the update of the Ubuntu base image but rather some other dependency.

@mauch
Copy link
Contributor

@mauch mauch commented Jan 9, 2020

@bmerry
Copy link
Contributor Author

@bmerry bmerry commented Jan 9, 2020

The last change was on 16 December, and contim successfully built at that time. So my guess is that it's some Ubuntu package that has been updated.

@sratcliffe
Copy link
Contributor

@sratcliffe sratcliffe commented Jan 9, 2020

@bmerry - so what should we do in the meantime. Tom has a patch for the image issues, but they container will obviously fail to build. I guess we either roll back the base Ubuntu version or we run an override on master controller to use an earlier (Dec 16) build of katsdpcontim.

@bmerry
Copy link
Contributor Author

@bmerry bmerry commented Jan 9, 2020

Rolling back the base Ubuntu version didn't help (that's effectively what this PR does).

For now we should probably just roll back katsdpcontim by pulling in last year's production tag of katsdpcontim when assembling the new staging tag.

@sratcliffe
Copy link
Contributor

@sratcliffe sratcliffe commented Jan 9, 2020

Agreed - plan is to build with current staging as the base and override controller to latest and katsdpcontim to the previous production tag.

@bmerry
Copy link
Contributor Author

@bmerry bmerry commented Jan 9, 2020

Since the failure doesn't seem to be linked to the update of ubuntu base, I'm going to update the python2 branch of katsdpdockerbase to match master, and then merge this PR.

@bmerry bmerry merged commit 560e5af into master Jan 10, 2020
1 check failed
1 check failed
continuous-integration/jenkins/branch This commit cannot be built
Details
@bmerry bmerry deleted the python2-build branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.