Created on 2020-01-18 20:25 by Kit Yan Choi, last changed 2020-09-19 09:32 by mark.dickinson. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 18067 | merged | Kit Yan Choi, 2020-01-19 17:21 | |
| PR 22317 | merged | mark.dickinson, 2020-09-19 09:32 | |
| Messages (4) | |||
|---|---|---|---|
| msg360250 - (view) | Author: Kit Yan Choi (Kit Yan Choi) * | Date: 2020-01-18 20:25 | |
assertLogs is really useful (issue18937). Unfortunately it does not cover the use cases where one wants to ensure no logs are emitted. Similar to assertLogs, we can have a context manager for asserting no logs, something like this?: with assertNoLogs(logger, level): ... If logs are unexpected found, the test would fail with the logs captured included in the error message. Happy to submit a PR if there is interest. |
|||
| msg367129 - (view) | Author: Rémi Lapeyre (remi.lapeyre) * | Date: 2020-04-23 16:34 | |
This makes sense, should assertNoWarns() be added too? |
|||
| msg367134 - (view) | Author: Kit Yan Choi (Kit Yan Choi) * | Date: 2020-04-23 17:39 | |
Thank you for looking into this. Yes, I agree it makes sense to have assertNoWarns for the same reason. |
|||
| msg372794 - (view) | Author: Vinay Sajip (vinay.sajip) *  |
Date: 2020-07-01 21:08 | |
New changeset 6b34d7b51e33fcb21b8827d927474ce9ed1f605c by Kit Choi in branch 'master': bpo-39385: Add an assertNoLogs context manager to unittest.TestCase (GH-18067) https://github.com/python/cpython/commit/6b34d7b51e33fcb21b8827d927474ce9ed1f605c |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2020-09-19 09:32:42 | mark.dickinson | set | nosy:
+ mark.dickinson pull_requests: + pull_request21362 |
| 2020-07-01 21:09:42 | vinay.sajip | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2020-07-01 21:08:42 | vinay.sajip | set | nosy:
+ vinay.sajip messages: + msg372794 |
| 2020-06-10 22:02:27 | remi.lapeyre | set | versions: + Python 3.10, - Python 3.9 |
| 2020-04-23 17:39:13 | Kit Yan Choi | set | messages: + msg367134 |
| 2020-04-23 16:34:46 | remi.lapeyre | set | nosy:
+ remi.lapeyre messages: + msg367129 |
| 2020-04-23 16:10:52 | francois.freitag | set | nosy:
+ francois.freitag |
| 2020-01-19 17:21:16 | Kit Yan Choi | set | keywords:
+ patch stage: patch review pull_requests: + pull_request17459 |
| 2020-01-19 15:28:05 | xtreak | set | nosy:
+ xtreak |
| 2020-01-19 11:19:13 | SilentGhost | set | nosy:
+ rbcollins, ezio.melotti, michael.foord versions: + Python 3.9 |
| 2020-01-18 20:25:23 | Kit Yan Choi | create | |