Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesbpo-37731: Reorder includes in xmltok.c to avoid redefinition of _POSIX_C_SOURCE #16733
Conversation
pablogsal
changed the title
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Oct 12, 2019
|
Thanks @pablogsal for the PR |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Oct 12, 2019
…IX_C_SOURCE (pythonGH-16733) (cherry picked from commit 8177404) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Oct 12, 2019
|
GH-16734 is a backport of this pull request to the 3.8 branch. |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Nov 7, 2019
|
Thanks @pablogsal for the PR |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Nov 7, 2019
|
GH-17076 is a backport of this pull request to the 2.7 branch. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Nov 7, 2019
…IX_C_SOURCE (pythonGH-16733) (cherry picked from commit 8177404) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Nov 7, 2019
jacobneiltaylor
added a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
…IX_C_SOURCE (pythonGH-16733)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pablogsal commentedOct 12, 2019
•
edited by miss-islington
https://bugs.python.org/issue37731
Automerge-Triggered-By: @pablogsal