classification
Title: Unused variable script_str in pysqlite_cursor_executescript
Type: Stage: resolved
Components: Library (Lib) Versions: Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: alex.henrie, berker.peksag
Priority: normal Keywords: patch

Created on 2020-01-30 04:19 by alex.henrie, last changed 2020-01-30 09:39 by berker.peksag. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 18271 merged alex.henrie, 2020-01-30 04:21
Messages (2)
msg361008 - (view) Author: Alex Henrie (alex.henrie) * Date: 2020-01-30 04:19 
The function pysqlite_cursor_executescript defines a variable called script_str, initializes it to NULL, and calls Py_XDECREF on it. However, this variable has been unused since August 2007: https://github.com/python/cpython/commit/6d21456137836b8acd551cf6a51999ad4ff10a91#diff-26f74db3527991715b482a5ed2603870L752
msg361028 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2020-01-30 09:39 
New changeset 1f44e775df8e7ec3ca60a1135cb3279f8b9dca3e by Alex Henrie in branch 'master':
bpo-39497: Remove unused variable from pysqlite_cursor_executescript (GH-18271)
https://github.com/python/cpython/commit/1f44e775df8e7ec3ca60a1135cb3279f8b9dca3e
History
Date User Action Args
2020-01-30 09:39:47berker.peksagsetstatus: open -> closed
type: performance ->
resolution: fixed
stage: patch review -> resolved
2020-01-30 09:39:32berker.peksagsetnosy: + berker.peksag
messages: + msg361028
2020-01-30 04:21:40alex.henriesetkeywords: + patch
stage: patch review
pull_requests: + pull_request17646
2020-01-30 04:19:15alex.henriecreate