Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRewrite docs for custom predicates #3560
Conversation
|
Looks good so far. Thank you! |
Co-Authored-By: Steve Piercy <web@stevepiercy.com>
|
Please note that I have made multiple commits for ease of review (and possibly revert), but the result should be a simple squashed changeset. |
|
Nice work. A few more changes from me, and then I'd like @mmerickel to do a final review. |
|
Thanks for the latest comments! I will wrap this up in the next day or two. |
|
|
With your suggested improvement in #3560 (comment) getting pushed to this branch, and trusting that the code samples are tested and actually work, I approve this PR. For testing the code, if it is possible to put it into a one-file app, or using the cookiecutter as a base, then I'd be happy to reproduce a run through. |
|
I’ll run a single-file test! |
|
The code seems to work well: https://gist.github.com/merwok/c17b11dfa4e462efc6ea0d8ea9585c0c Running a linter found a warning, now fixed. |
Fixes #1161