Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite docs for custom predicates #3560

Merged
merged 14 commits into from Jan 17, 2020

Conversation

@merwok
Copy link
Contributor

@merwok merwok commented Jan 7, 2020

Fixes #1161

docs/narr/urldispatch.rst Show resolved Hide resolved
docs/narr/urldispatch.rst Outdated Show resolved Hide resolved
docs/narr/urldispatch.rst Outdated Show resolved Hide resolved
docs/narr/viewconfig.rst Show resolved Hide resolved
src/pyramid/config/routes.py Show resolved Hide resolved
docs/narr/viewconfig.rst Show resolved Hide resolved
Copy link
Member

@stevepiercy stevepiercy left a comment

Looks good so far. Thank you!

docs/narr/urldispatch.rst Outdated Show resolved Hide resolved
docs/narr/urldispatch.rst Outdated Show resolved Hide resolved
docs/narr/urldispatch.rst Outdated Show resolved Hide resolved
docs/narr/urldispatch.rst Outdated Show resolved Hide resolved
docs/narr/urldispatch.rst Outdated Show resolved Hide resolved
docs/narr/viewconfig.rst Outdated Show resolved Hide resolved
docs/quick_tour.rst Show resolved Hide resolved
src/pyramid/config/routes.py Show resolved Hide resolved
src/pyramid/config/routes.py Outdated Show resolved Hide resolved
src/pyramid/config/views.py Outdated Show resolved Hide resolved
Co-Authored-By: Steve Piercy <web@stevepiercy.com>
@merwok
Copy link
Contributor Author

@merwok merwok commented Jan 11, 2020

Please note that I have made multiple commits for ease of review (and possibly revert), but the result should be a simple squashed changeset.

HISTORY.rst Show resolved Hide resolved
@merwok merwok marked this pull request as ready for review Jan 11, 2020
@merwok merwok requested a review from stevepiercy Jan 11, 2020
Copy link
Member

@stevepiercy stevepiercy left a comment

Nice work. A few more changes from me, and then I'd like @mmerickel to do a final review.

docs/narr/urldispatch.rst Outdated Show resolved Hide resolved
HISTORY.rst Show resolved Hide resolved
docs/quick_tour.rst Outdated Show resolved Hide resolved
src/pyramid/config/routes.py Show resolved Hide resolved
src/pyramid/config/routes.py Outdated Show resolved Hide resolved
src/pyramid/config/routes.py Show resolved Hide resolved
src/pyramid/config/views.py Show resolved Hide resolved
src/pyramid/config/routes.py Outdated Show resolved Hide resolved
docs/narr/urldispatch.rst Outdated Show resolved Hide resolved
@merwok
Copy link
Contributor Author

@merwok merwok commented Jan 13, 2020

Thanks for the latest comments! I will wrap this up in the next day or two.

@merwok
Copy link
Contributor Author

@merwok merwok commented Jan 14, 2020

  • one small wording issue open
  • question about info/config param
  • should probably test the example code just to be sure
@merwok merwok requested review from stevepiercy and mmerickel Jan 14, 2020
Copy link
Member

@stevepiercy stevepiercy left a comment

With your suggested improvement in #3560 (comment) getting pushed to this branch, and trusting that the code samples are tested and actually work, I approve this PR.

For testing the code, if it is possible to put it into a one-file app, or using the cookiecutter as a base, then I'd be happy to reproduce a run through.

@merwok
Copy link
Contributor Author

@merwok merwok commented Jan 15, 2020

I’ll run a single-file test!

@stevepiercy stevepiercy added this to the 2.0 milestone Jan 16, 2020
merwok added 2 commits Jan 16, 2020
@merwok
Copy link
Contributor Author

@merwok merwok commented Jan 17, 2020

The code seems to work well: https://gist.github.com/merwok/c17b11dfa4e462efc6ea0d8ea9585c0c

Running a linter found a warning, now fixed.

@mmerickel mmerickel merged commit 03d3bbd into Pylons:master Jan 17, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@merwok merwok deleted the merwok:docs/rewrite-custom-predicates branch Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.