Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Issue #37 - Ignore non errors on Windows #38
Conversation
…2c72d9f5b466ac49250b7a76bb3.patch to faulthandler backport This prevents the Windows Exception handling from logging non error exceptions
|
Travis tests seemed to have some issue running, but I have run the tests with Python 2.7.16 and the new test passes |
|
Thanks for the PR. I just have one request. I want the faulthandler backport to strictly stick to the same code/feature set than Python upstream. New features should land first in Python. |
| for exc_code in ( | ||
| 0xE06D7363, # MSC exception ("Emsc") | ||
| 0xE0434352, # COM Callable Runtime exception ("ECCR") | ||
| 0x40010006, # Debug Print exception |
vstinner
Jan 27, 2020
Owner
I'm ok with with this additional test, but I would prefer to first get it in Python upstream. Can you try to create a PR on Python to add this test? Please remove 0x40010006.
I'm ok with with this additional test, but I would prefer to first get it in Python upstream. Can you try to create a PR on Python to add this test? Please remove 0x40010006.
vstinner
Jan 27, 2020
Owner
If you don't want to create a PR on Python, I can do it. Tell me what you prefer.
If you don't want to create a PR on Python, I can do it. Tell me what you prefer.
dee42
Jan 27, 2020
Author
I can just remove it. I added it because it was the specific exception which was causing me issues, so I wanted to explicitly test on Windows that the case was fixed. I don't think there's any need to keep it.
I can just remove it. I added it because it was the specific exception which was causing me issues, so I wanted to explicitly test on Windows that the case was fixed. I don't think there's any need to keep it.
|
LGTM. Thanks for the PR! |
|
faulthandler 3.2 released with your fix. |
This ports python/cpython@2e4eee2 to Python 2 and to this backport of the faulthandler. It prevents logging of non-error Windows exceptions, which can fill up a logfile very quickly with spurious tracebacks.