Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Flatten known data structures when computing group SHAs #1356
Comments
|
We don't necessarily need to flatten for the grouping, we can sometimes replace one line with another. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the common part of a leaktrace uses data structures that rely on linked lists (e.g. LinkedHashMap) then the leak trace has a different size for every leak, despite being the same, which prevents good grouping.
There should be a way to transform the subset of the leaktrace that forms the group into a synthetic version that always ends up being the same. We'll need this for hashing but also displaying the group. The real leak trace should display as before when you dive in.
Probably shouldn't be an API at first, we can start with a few JDK data structures (LinkedHashMap, LinkedHashSet, LinkedList)