Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't use xfail for failure scenarios (#155) #33
Merged
Conversation
When testing for sources that we know should raise SyntaxError we should
check explicitly that the parser raises such exception instead of
marking the cases as 'xfail'. As per the pytest docs:
A xfail means that you expect a test to fail for some reason. A common
example is a test for a feature not yet implemented, or a bug not yet
fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sthagen commentedJan 15, 2020
When testing for sources that we know should raise SyntaxError we should
check explicitly that the parser raises such exception instead of
marking the cases as 'xfail'. As per the pytest docs: