➜
This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to
log in and link your GitHub username to your profile.
For more information,
see this post about the migration.
Created on 2019-06-18 02:36 by indygreg, last changed 2019-09-11 13:31 by miss-islington. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 15921 | merged | steve.dower, 2019-09-11 11:18 | |
| PR 15932 | merged | miss-islington, 2019-09-11 12:43 | |
| Messages (6) | |||
|---|---|---|---|
| msg345944 - (view) | Author: Gregory Szorc (indygreg) * | Date: 2019-06-18 02:36 | |
The Modules/_ctypes/libffi_msvc/ffi.h and Modules/_ctypes/libffi_osx/include/ffi.h files in the CPython repository contain copies of libffi. On at least the official Windows distributions, the LICENSE.txt does not contain libffi's license text from these files. This is seemingly in violation of libffi's license agreement, which clearly says "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software." |
|||
| msg345948 - (view) | Author: Ammar Askar (ammar2) *  |
Date: 2019-06-18 02:56 | |
LICENSE.txt only contains Python's licensing information. You can find all the external licenses in https://docs.python.org/3/license.html?highlight=libffi#libffi On Windows, this is also distributed as part of Doc/pythonXXX.chm If you don't think this is sufficient, feel free to re-open. |
|||
| msg345949 - (view) | Author: Gregory Szorc (indygreg) * | Date: 2019-06-18 03:09 | |
FWIW LICENSE.txt on Windows contains licenses for additional projects starting on line 258 (at least in CPython 3.7.3), which contains the section header "Additional Conditions for this Windows binary build". But, the Doc/pythonXXX.chm does indeed contain libffi's license text. So we're all good here. I'm not sure why LICENSE.txt on Windows is incomplete. *shrugs* |
|||
| msg345950 - (view) | Author: Ammar Askar (ammar2) * |
Date: 2019-06-18 03:22 | |
Oh whoops, I was looking at my py2 folder. Let's reopen in that case. |
|||
| msg351844 - (view) | Author: Zachary Ware (zach.ware) * |
Date: 2019-09-11 12:43 | |
New changeset 8fcaffb048d2359a4c06ed5d8fbbf46d3ae1a472 by Zachary Ware (Steve Dower) in branch 'master': bpo-37326: Include libffi license when available (GH-15921) https://github.com/python/cpython/commit/8fcaffb048d2359a4c06ed5d8fbbf46d3ae1a472 |
|||
| msg351866 - (view) | Author: miss-islington (miss-islington) | Date: 2019-09-11 13:31 | |
New changeset da38ec1d4862ffb58faec41ed367719e81801766 by Miss Islington (bot) in branch '3.8': bpo-37326: Include libffi license when available (GH-15921) https://github.com/python/cpython/commit/da38ec1d4862ffb58faec41ed367719e81801766 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2019-09-11 13:31:30 | miss-islington | set | nosy:
+ miss-islington messages: + msg351866 |
| 2019-09-11 13:03:35 | steve.dower | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2019-09-11 12:43:12 | miss-islington | set | pull_requests: + pull_request15571 |
| 2019-09-11 12:43:04 | zach.ware | set | messages: + msg351844 |
| 2019-09-11 11:18:03 | steve.dower | set | keywords:
+ patch stage: patch review pull_requests: + pull_request15562 |
| 2019-09-11 11:17:07 | steve.dower | set | assignee: steve.dower versions: - Python 3.5, Python 3.6, Python 3.7 |
| 2019-06-18 03:22:08 | ammar2 | set | status: closed -> open components: + Windows title: Python distributions do not contain libffi license -> Windows LICENSE.txt do not contain libffi license nosy: + zach.ware, paul.moore, tim.golden, steve.dower versions: - Python 2.7 messages: + msg345950 resolution: not a bug -> (no value) stage: resolved -> (no value) |
| 2019-06-18 03:09:12 | indygreg | set | messages: + msg345949 |
| 2019-06-18 02:56:16 | ammar2 | set | status: open -> closed nosy: + ammar2 messages: + msg345948 resolution: not a bug stage: resolved |
| 2019-06-18 02:36:56 | indygreg | create | |