Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39320: Don't use an oparg for new DICT_* opcodes. #18243

Open
wants to merge 4 commits into
base: master
from
Open

bpo-39320: Don't use an oparg for new DICT_* opcodes. #18243

wants to merge 4 commits into from
+146 −145

Conversation

@brandtbucher
Copy link
Member

brandtbucher commented Jan 29, 2020 •
edited by bedevere-bot

The oparg for these new, simpler opcodes is always 1. @markshannon

https://bugs.python.org/issue39320
@brandtbucher
Remove the oparg from DICT_MERGE and DICT_UPDATE.
70a59b4
@brandtbucher
Update the documentation.
e0a7d68
@brandtbucher
Regenerate everything.
0929b55
@brandtbucher
Add a NEWS entry.
Loading status checks…
c977313
@brandtbucher brandtbucher reopened this Jan 29, 2020
@markshannon

This comment has been minimized.

Sign in to view
Copy link
Contributor

markshannon commented Jan 29, 2020

I'd prefer to keep the new opcodes as they are.

There is no efficiency gain in ignoring the oparg, as it is always pre-computed during dispatch.
Allowing flexible access into the stack may allow compiler optimisations that your change would prevent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed awaiting review type-enhancement
Projects
None yet
Milestone
No milestone
4 participants
@brandtbucher @markshannon @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.