New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assemble documentation is wrong/outdated about decrypt parameters
#65450
Comments
|
Files identified in the description: If these files are inaccurate, please update the |
|
This appears to be a bug, it should work as documented. I think the fix is basically: diff --git a/lib/ansible/plugins/action/assemble.py b/lib/ansible/plugins/action/assemble.py
index d874c7090b..6ec456b586 100644
--- a/lib/ansible/plugins/action/assemble.py
+++ b/lib/ansible/plugins/action/assemble.py
@@ -97,7 +97,7 @@ class ActionModule(ActionBase):
regexp = self._task.args.get('regexp', None)
follow = self._task.args.get('follow', False)
ignore_hidden = self._task.args.get('ignore_hidden', False)
- decrypt = self._task.args.get('decrypt', True)
+ decrypt = self._task.args.pop('decrypt', True)
try:
if src is None or dest is None:But this will need tested, a PR created with a changelog and integration tests to validate the functionality. |
|
@quartin the actual module doesn't care about But I can see from a validate-modules perspective (CI test), that we would have to continue to ignoring a mismatch between |
|
Hey @sivel , I was wondering if I can work on this? |
|
Making the above change or adding decrypt to argument_spec both remove the error. However, decryption doesn't actually occur unless remote_src is explicitly set to no. Is this expected behaviour? |
|
Files identified in the description: If these files are incorrect, please update the |
v2.9.11 ======= Minor Changes ------------- - The ``items2dict`` filter can now create a dict whose values are the original elements of the input list, and whose keys are the value of some key in each dict. When the resulting dict is stored, this allows for O(1) lookup of a particular key without having to scan the entire list each time. - k8s - update openshift requirements in documentation - pipe lookup - update docs for Popen with shell=True usages (ansible/ansible#70159). Bugfixes -------- - Allow TypeErrors on Undefined variables in filters to be handled or deferred when processing for loops. - Fix ``delegate_facts: true`` when ``ansible_python_interpreter`` is not set. (ansible/ansible#70168) - Support check mode in NXOS BGP modules (ansible/ansible#57360). - TaskExecutor - Handle unexpected errors as failed while post validating loops (ansible/ansible#70050). - The `ansible_become` value was not being treated as a boolean value when set in an INI format inventory file (fixes bug ansible/ansible#70476). - To fix ios_l2_interfaces facts parsing issue (ansible-collections/cisco.ios#59) - To fix ios_user and ios_command test case failure fix (ansible-collections/cisco.ios#82) - Vault - Allow single vault encrypted values to be used directly as module parameters. (ansible/ansible#68275) - add constraints file for ``anisble_runner`` test since an update to ``psutil`` is now causing test failures - ansible-galaxy - Instead of assuming the first defined server is galaxy, filter based on the servers that support the v1 API, and return the first of those (ansible/ansible#65440) - ansible-test no longer tracebacks during change analysis due to processing an empty python file - ansible-test now correctly recognizes imports in collections when using the ``--changed`` option. - ansible-test now ignores empty ``*.py`` files when analyzing module_utils imports for change detection - assemble - fix decrypt argument in the module (ansible/ansible#65450). - docker_container - various error fixes in string handling for Python 2 to avoid crashes when non-ASCII characters are used in strings (ansible-collections/community.general#640). - eos_eapi - enable eapi by default - group_by now should correctly refect changed status. - json callback - Fix host result to task references in the resultant JSON output for non-lockstep strategy plugins such as free (ansible/ansible#65931) - nmcli - Add compatibility for new networkmanager library (ansible/ansible#65726). - puppet - fix command line construction for check mode and ``manifest:`` (ansible/ansible#60576). - selective callback - mark task failed correctly (ansible/ansible#63767). - windows async - use full path when calling PowerShell to reduce reliance on environment vars being correct - ansible/ansible#70655 - winrm - preserve winrm forensic data on put_file failures
SUMMARY
I would like to assemble files into one with
assemblemodule. Documentation said it can decrypt files. After a few tests withAnsible 2.9I discover that parameter not implemented.That argument should be available since
Ansible 2.4. Which is wrong, documentation or the module?ISSUE TYPE
COMPONENT NAME
assemble, core module.ANSIBLE VERSION
CONFIGURATION
OS / ENVIRONMENT
Local task on Voidlinux with
linux 5.3.14_1.STEPS TO REPRODUCE
With encrypted files in
certificates/directory.EXPECTED RESULTS
A file should be created from other files assemble, like
cat file1 file2 file3 > new_filebut uncrypted.ACTUAL RESULTS
The text was updated successfully, but these errors were encountered: