Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the email notifier report #149

Merged
merged 1 commit into from Jan 15, 2020
Merged

Conversation

@pablogsal
Copy link
Member

pablogsal commented Jan 15, 2020

Add similar report information as the PR notifier plugin to improve
the triaging experience.

@pablogsal
Copy link
Member Author

pablogsal commented Jan 15, 2020

@vstinner @zware Behold an example of how the new improved email will look like :)

The Buildbot has detected a build exception on builder Test Builder 3.x while building Python.
Full details are available at:
    http://localhost:9011/#builders/271/builds/14

Buildbot URL: http://localhost:9011/

Worker for this Build: local-worker

Build Reason: 
Blamelist: 

BUILD FAILED: 


Summary of the results of the build (if available):
===================================================

== Tests result: FAILURE ==

1 test failed:
    test_list

Total duration: 423 ms


Captured traceback
==================

Traceback (most recent call last):
      File "/home/pablogsal/github/buildmaster-config/master/workers/local-worker/3.x.local-worker/build/Lib/test/test_list.py", line 61, in test_len
        self.assertEqual(len([0, 1, 2]), 4)
    AssertionError: 3 != 4


Test report
===========

Failed tests:

- test_list


Sincerely,
 -The Buildbot
@pablogsal pablogsal force-pushed the pablogsal:better_email branch 3 times, most recently from 81287c1 to 954e304 Jan 15, 2020
@pablogsal pablogsal requested review from zware and vstinner Jan 15, 2020
@zware
zware approved these changes Jan 15, 2020
Copy link
Member

vstinner left a comment

It didn't read the implementation, but the example looks great! I let you merge the PR and deploy it.

Add similar report information as the PR notifier plugin to improve
the triaging experience.
@pablogsal pablogsal force-pushed the pablogsal:better_email branch from 954e304 to cf1fd29 Jan 15, 2020
@pablogsal pablogsal merged commit 3cb8ad8 into python:master Jan 15, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pablogsal pablogsal deleted the pablogsal:better_email branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.